Fixed S360 alert: Newtonsoft.Json upgrade (#363)

* Bump Newtonsoft.Json to 13.0.1

* Fixed tests on the path's format

* Fixed warnings in tests

* Bumped version

* Bumped to latest stable version

Author: raych1

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.11.0 2025-08-11
+
+- upgraded Newtonsoft.Json from 9.0.1 to 13.0.1
+
 ## 0.10.14 2025-06-19
 
 - escaped the input string when construct the autorest command

openapi-diff/src/core/OpenApiDiff.Core/OpenApiDiff.Core.csproj

@@ -17,7 +17,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageReference Include="System.Net.Http" Version="4.3.4" />
     <PackageReference Include="System.Reflection.TypeExtensions" Version="4.3.0" />
     <PackageReference Include="YamlDotNet.Signed" Version="5.0.0" />

openapi-diff/src/core/OpenApiDiff/OpenApiDiff.csproj

@@ -19,7 +19,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="$(SolutionDir)src/modeler/AutoRest.Swagger/AutoRest.Swagger.csproj" />

openapi-diff/src/modeler/AutoRest.Swagger.Tests/SwaggerModelerCompareTests.cs

@@ -309,7 +309,7 @@ public void AddedPaths()
             var raw = JToken.Parse(output);
             Assert.Equal(JTokenType.Object, raw.Type);
             Assert.Equal("new/added_path.json:38:15", raw["new"]["location"].Value<string>());
-            Assert.Equal("paths./api/Operations.post", raw["new"]["path"].Value<string>());
+            Assert.Equal("paths['/api/Operations'].post", raw["new"]["path"].Value<string>());
             Assert.Null(raw["old"]["location"]);
         }
 
@@ -368,7 +368,7 @@ public void AddedReadOnlyRequiredProperty()
             ComparisonMessage[] messages = CompareSwagger("added_readonly_required_property.json").ToArray();
             List<ComparisonMessage> addedReqPropMessages = messages.Where(
                 m => m.Severity == Category.Error && m.Id == ComparisonMessages.AddedRequiredProperty.Id).ToList();
-            Assert.Equal(0, addedReqPropMessages.Count);
+            Assert.Empty(addedReqPropMessages);
         }
 
         /// <summary>
@@ -842,21 +842,21 @@ public void GlobalResponseTypeConstraintsChanged()
         public void RemovedPropertyTest()
         {
             var messages = CompareSwagger("removed_property.json").ToArray();
-            Assert.True(messages.Where(m => m.Id == ComparisonMessages.RemovedProperty.Id).Any());
+            Assert.NotEmpty(messages.Where(m => m.Id == ComparisonMessages.RemovedProperty.Id));
         }
 
         [Fact]
         public void FormatChanged()
         {
             var messages = CompareSwagger("format_check_01.json").ToArray();
-            Assert.True(messages.Where(m => m.Id == ComparisonMessages.TypeFormatChanged.Id).Any());
+            Assert.NotEmpty(messages.Where(m => m.Id == ComparisonMessages.TypeFormatChanged.Id));
         }
 
         [Fact]
         public void FormatRemoved()
         {
             var messages = CompareSwagger("format_check_02.json").ToArray();
-            Assert.True(messages.Where(m => m.Id == ComparisonMessages.TypeFormatChanged.Id).Any());
+            Assert.NotEmpty(messages.Where(m => m.Id == ComparisonMessages.TypeFormatChanged.Id));
         }
 
         [Fact]
@@ -952,7 +952,7 @@ public void DidNotChangeGlobalParameterOrder()
             // of Implicit and Client doesn't matter.
             //
             // Reference: https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-parameter-location
-            Assert.Equal(0, messages.Where(m => m.Id == ComparisonMessages.ChangedParameterOrder.Id).Count());
+            Assert.Empty(messages.Where(m => m.Id == ComparisonMessages.ChangedParameterOrder.Id));
         }
 
         [Fact]
@@ -1047,11 +1047,11 @@ public void ParameterRemoved()
 
             foreach (var reqParamName in reqParamNames)
             {
-                Assert.True(reqParamMessageStrings.Any(str => str.Contains(reqParamName)));
+                Assert.Contains(reqParamMessageStrings, str => str.Contains(reqParamName));
             }
             foreach (var optParamName in optParamNames)
             {
-                Assert.True(optParamMessageStrings.Any(str => str.Contains(optParamName)));
+                Assert.Contains(optParamMessageStrings, str => str.Contains(optParamName));
             }
         }
     }

openapi-diff/src/modeler/AutoRest.Swagger/AutoRest.Swagger.csproj

@@ -10,7 +10,8 @@
     <LangVersion>7.3</LangVersion>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
+    <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\..\core\OpenApiDiff.Core\OpenApiDiff.Core.csproj" />

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/oad",
-  "version": "0.10.14",
+  "version": "0.11.0",
   "author": {
     "name": "Microsoft Corporation",
     "email": "azsdkteam@microsoft.com",

package.json

@@ -38,7 +38,7 @@ test("Additional Properties is boolean", async () => {
       mode: "Addition",
       new: {
         location: ``,
-        path: "paths./api/Operations.get.parameters",
+        path: "paths['/api/Operations'].get.parameters",
         ref: ``
       },
       old: {},

src/test/additionalPropertiesIsBooleanTest.ts

@@ -39,7 +39,7 @@ test("common-parameters", async () => {
       new: {},
       old: {
         location: "",
-        path: "paths./api/Operations.get.parameters",
+        path: "paths['/api/Operations'].get.parameters",
         ref: ""
       },
       type: "Error"
@@ -52,7 +52,7 @@ test("common-parameters", async () => {
       mode: "Addition",
       new: {
         location: "",
-        path: "paths./api/Operations.get.parameters",
+        path: "paths['/api/Operations'].get.parameters",
         ref: ""
       },
       old: {},

src/test/commonParametersTest.ts

@@ -36,12 +36,12 @@ test("expands allOf full covers", async () => {
       message: "The new version has a different 'allOf' property than the previous one.",
       old: {
         ref: `${oldFilePath}#/paths/~1api~1Parameters/put/parameters/0/schema`,
-        path: "paths./api/Parameters.put.parameters[0].schema",
+        path: "paths['/api/Parameters'].put.parameters[0].schema",
         location: `${oldFilePath}:22:13`
       },
       new: {
         ref: `${newFilePath}#/paths/~1api~1Parameters/put/parameters/0/schema`,
-        path: "paths./api/Parameters.put.parameters[0].schema",
+        path: "paths['/api/Parameters'].put.parameters[0].schema",
         location: `${newFilePath}:22:13`
       },
       type: "Error",
@@ -109,12 +109,12 @@ test("expands allOf full covers", async () => {
         "The new version lists new non-read-only properties as required: 'a'. These properties were not listed as required in the old version.",
       old: {
         ref: `${oldFilePath}#/paths/~1api~1Parameters/put/parameters/0/schema`,
-        path: "paths./api/Parameters.put.parameters[0].schema",
+        path: "paths['/api/Parameters'].put.parameters[0].schema",
         location: `${oldFilePath}:22:13`
       },
       new: {
         ref: `${newFilePath}#/paths/~1api~1Parameters/put/parameters/0/schema`,
-        path: "paths./api/Parameters.put.parameters[0].schema",
+        path: "paths['/api/Parameters'].put.parameters[0].schema",
         location: `${newFilePath}:22:13`
       },
       type: "Error",