escaped quote for windows

Author: raych1

src/lib/validators/openApiDiff.ts

@@ -83,8 +83,26 @@ const updateChangeProperties = (change: ChangeProperties, pf: ProcessedFile): Ch
   }
 }
 
-function escape(filePath: string) {
-  return `"${filePath}"`
+/**
+ * Safely escapes shell arguments for cross-platform compatibility
+ * @param arg The argument to escape
+ * @returns The safely escaped argument
+ */
+function escapeShellArg(arg: string): string {
+  if (typeof arg !== "string") {
+    throw new Error("Argument must be a string")
+  }
+
+  if (process.platform === "win32") {
+    // For Windows cmd.exe, wrap in double quotes and escape internal quotes
+    // This handles paths with spaces and special characters safely
+    // Double quotes are escaped by doubling them in Windows
+    return `"${arg.replace(/"/g, '""')}"`
+  } else {
+    // On Unix-like systems, use shell-quote for proper escaping
+    // shell-quote handles all edge cases including spaces, special chars, etc.
+    return quote([arg])
+  }
 }
 
 /**
@@ -232,12 +250,12 @@ export class OpenApiDiff {
     const outputFolder = await fs.promises.mkdtemp(path.join(os.tmpdir(), "oad-"))
     const outputFilePath = path.join(outputFolder, `${outputFileName}.json`)
     const outputMapFilePath = path.join(outputFolder, `${outputFileName}.map`)
-    // quote behavior is validated in shellEscapingTest.ts
+    // Cross-platform shell argument escaping - behavior is validated in shellEscapingTest.ts
     const autoRestCmd = tagName
-      ? `${this.autoRestPath()} ${quote([swaggerPath])} --v2 --tag=${quote([tagName])} --output-artifact=swagger-document.json` +
-        ` --output-artifact=swagger-document.map --output-file=${quote([outputFileName])} --output-folder=${quote([outputFolder])}`
-      : `${this.autoRestPath()} --v2 --input-file=${quote([swaggerPath])} --output-artifact=swagger-document.json` +
-        ` --output-artifact=swagger-document.map --output-file=${quote([outputFileName])} --output-folder=${quote([outputFolder])}`
+      ? `${this.autoRestPath()} ${escapeShellArg(swaggerPath)} --v2 --tag=${escapeShellArg(tagName)} --output-artifact=swagger-document.json` +
+        ` --output-artifact=swagger-document.map --output-file=${escapeShellArg(outputFileName)} --output-folder=${escapeShellArg(outputFolder)}`
+      : `${this.autoRestPath()} --v2 --input-file=${escapeShellArg(swaggerPath)} --output-artifact=swagger-document.json` +
+        ` --output-artifact=swagger-document.map --output-file=${escapeShellArg(outputFileName)} --output-folder=${escapeShellArg(outputFolder)}`
 
     log.debug(`Executing: "${autoRestCmd}"`)