Merge pull request #6 from jim-minter/canset-bug

fix CanSet check in wrong place plus unit test

Author: bfoley13

redact.go

@@ -61,14 +61,14 @@ func redact(v reflect.Value, tag string) {
 		}
 
 	case reflect.String:
-		if v.CanSet() {
-			v.SetString(transformString(v.String(), tag))
-		}
+		v.SetString(transformString(v.String(), tag))
 
 	case reflect.Struct:
 		for i := 0; i < v.NumField(); i++ {
-			tag, _ := v.Type().Field(i).Tag.Lookup(tagName)
-			redact(v.Field(i), tag)
+			if v.Field(i).CanSet() {
+				tag, _ := v.Type().Field(i).Tag.Lookup(tagName)
+				redact(v.Field(i), tag)
+			}
 		}
 	}
 }

redact_test.go

@@ -25,6 +25,7 @@ type TestStruct struct {
 	SecretPtr        *string
 	NonSecret        string `redact:"nonsecret"`
 	unexported       string
+	unexportedMap    map[string]string
 }
 
 type TestStructList struct {
@@ -57,6 +58,7 @@ func TestStringTestStruct(t *testing.T) {
 			SecretStringType: secretVal,
 			SecretPtr:        &secretPtrVal,
 			unexported:       nonSecretVal,
+			unexportedMap:    map[string]string{"": ""},
 		}
 
 		err := redact.Redact(tStruct)