Fix attribute name casing and streamline node attribute processing in ClusterStatusChecker

Author: devanshjainms

src/modules/get_cluster_status_scs.py

@@ -79,7 +79,7 @@ def _process_node_attributes(self, node_attributes: ET.Element) -> Dict[str, Any
         :return: A dictionary containing the primary and secondary node information, plus cluster status.
         :rtype: Dict[str, Any]
         """
-        attribute_name = f"runs_ers_{self.sap_sid}"
+        attribute_name = f"runs_ers_{self.sap_sid.upper()}"
         for node in node_attributes:
             for attribute in node:
                 if attribute.attrib["name"] == attribute_name:
@@ -137,9 +137,7 @@ def run(self) -> Dict[str, str]:
                         self.result["message"] = f"Node {node.attrib['name']} is not online"
                         self.log(logging.WARNING, self.result["message"])
 
-                self.result.update(
-                    self._process_node_attributes(cluster_status_xml.find("node_attributes"))
-                )
+                self._process_node_attributes(cluster_status_xml.find("node_attributes"))
 
             if self.result["ascs_node"] == "" or self.result["ers_node"] == "":
                 self.result["message"] = (