Added support for SAP HANA SR Angi, offline validation of cluster resource parameters, support for SLES and RHEL management server #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r SUSE and REDHAT as management server
…ame dynamically (#95)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces comprehensive improvements to the SAP high availability testing framework by adding support for SAP HANA SR Angi, offline validation capabilities, extended operating system support, and improved modularity. The changes enhance testing flexibility and accuracy across different SAP configurations.
Key changes:
- Added support for SAP HANA SR Angi provider alongside traditional SAPHanaSR
- Introduced offline validation functionality for testing cluster configurations using pre-collected CIB XML files
- Refactored parameter handling to use enums and improve type safety across modules
- Enhanced credential management and documentation for multiple authentication methods
Reviewed Changes
Copilot reviewed 91 out of 93 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/modules/ |
Updated test modules to use enum-based operating system handling and removed deprecated ansible_os_family parameters |
src/roles/misc/tasks/ |
Added new offline validation tasks and updated existing tasks to support HANA SR Angi provider detection |
src/modules/ |
Refactored modules to use centralized enums and removed hardcoded string comparisons for OS families |
src/vars/input-api.yaml |
Added new commands and test cases for offline validation and HANA SR Angi support |
src/playbook_01_ha_offline_tests.yml |
New playbook specifically for offline validation testing scenarios |
KimForss
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across documentation, workflow configuration, and the main test automation script to enhance SAP high availability testing and validation. The most significant changes include expanded OS and cluster configuration support, new documentation for offline validation, improved credential management, and refactoring of the main test script for better usability and extensibility.
Documentation Improvements:
OFFLINE_VALIDATION.mdguide detailing how to perform offline validation of SAP HANA and Central Services clusters using previously collected CIB XML files, including setup instructions, directory structure, and usage examples.Test Automation Script Enhancements (
scripts/sap_automation_qa.sh):Workflow Configuration Updates:
github/codeql-actionin GitHub workflow files (.github/workflows/codeql.yml,ossf-scoreboard.yml,trivy.yml) to use versionv3.28.20for improved security and compatibility. [1] [2] [3]These changes collectively improve the flexibility, maintainability, and clarity of the SAP automation QA framework, making it easier to validate high availability configurations both online and offline, and to run targeted test scenarios across supported platforms.