Resource validation for azure events #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devanshjainms
requested review from
KimForss,
Copilot and
hdamecharla
and removed request for
Copilot
…ired parameters and update warning messages for missing resources
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces comprehensive validation for required cluster resources, particularly adding support for the new azureevents resource type. The changes implement systematic checking of required resources and generate appropriate warnings when resources are missing from the cluster configuration.
- Adds new
_check_required_resourcesmethod to validate presence of required cluster resources - Integrates the new
azureeventsresource into the validation framework for both SUSE and REDHAT systems - Expands test coverage to validate the new resource checking functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/module_utils/get_pcmk_properties.py | Implements core _check_required_resources method with logging and warning generation |
| src/modules/get_pcmk_properties_db.py | Adds azureevents resource category and integrates required resource checking |
| src/modules/get_pcmk_properties_scs.py | Integrates required resource checking into SCS validation flow |
| src/roles/ha_db_hana/tasks/files/constants.yaml | Defines azureevents resource configuration for both SUSE and REDHAT OS types |
| tests/module_utils/get_pcmk_properties_test.py | Adds comprehensive tests for required resource validation scenarios |
KimForss
previously approved these changes
Oct 14, 2025
…to improve logging and message clarity
devanshjainms
dismissed stale reviews from KimForss and hdamecharla
via
af35d6f
…rces in HA cluster validator
…ability in report
mkdeegan
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhanced validation for required cluster resources, particularly focusing on the new
azureeventsresource. It ensures that required resources are checked and appropriate warnings are generated when any are missing. The changes also expand test coverage for resource validation and improve robustness in command execution mocks.Resource validation enhancements:
_check_required_resourcesmethod toget_pcmk_properties.pyto check for required resources defined inRESOURCE_DEFAULTSand append warnings to the result message if any are missing._check_required_resourcesinto the resource validation flow for both HANA (get_pcmk_properties_db.py) and SCS (get_pcmk_properties_scs.py) modules, ensuring required resources are checked during validation. [1] [2]Support for new resource type:
azureeventsas a required resource in theRESOURCE_DEFAULTSsection ofconstants.yamlfor both SUSE and REDHAT OS types, including its meta attributes and operations. [1] [2]RESOURCE_CATEGORIESinget_pcmk_properties_db.pyto include theazureeventsresource type.Testing improvements:
get_pcmk_properties_test.pyto cover scenarios where required resources are missing, present, or optional, ensuring the new validation logic works as expected.Logging improvements:
loggingmodule inget_pcmk_properties.pyto support warning messages when required resources are missing.