Skip to content

Commit 9621016

Browse files
authored
[Mellanox] Stop SDK monitor thread before syncd shutdown (#24079)
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it To avoid error message is syslog during shutdown flow related to SDK monitor thread. Error message was observed only during shutdown flow, hence there was no functional impact, just error log. It was not always reproducible because the reason for it was race condition related to monitor thread. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it During shutdown flow stop SDK monitor thread before actual SDK shutdown in order to avoid race condition. #### How to verify it By running any type of reboot or config reload <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
1 parent ffdd8de commit 9621016

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

files/scripts/syncd.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,10 @@ function stopplatform1() {
9696
debug "Stopped pmon service"
9797
fi
9898

99+
if [[ x$sonic_asic_platform == x"mellanox" ]]; then
100+
echo "health_check_trigger del_dev 1" > /proc/mlx_sx/sx_core
101+
fi
102+
99103
if [[ x$sonic_asic_platform != x"mellanox" ]] || [[ x$TYPE != x"cold" ]]; then
100104
# Invoke platform specific pre shutdown routine.
101105
PLATFORM=`$SONIC_DB_CLI CONFIG_DB hget 'DEVICE_METADATA|localhost' platform`

0 commit comments

Comments
 (0)