Fix Missing Metadata update on InMemoryGroupProvider.cs (#82)

* Using PredicateBuilder for querying Users and Groups

* Update InMemoryUserProvider.cs

* Fixing Typo in ProtocolExtensions.cs

* fix missing metadata on groups provider

Co-authored-by: Cecily King'ori <[email protected]>

Author: CecilyK

Microsoft.SCIM.WebHostSample/Provider/InMemoryGroupProvider.cs

@@ -44,6 +44,10 @@ public override Task<Resource> CreateAsync(Resource resource, string correlation
             {
                 throw new HttpResponseException(HttpStatusCode.Conflict);
             }
+            //Update Metadata
+            DateTime created = DateTime.UtcNow;
+            group.Metadata.Created = created;
+            group.Metadata.LastModified = created;
 
             string resourceIdentifier = Guid.NewGuid().ToString();
             resource.Identifier = resourceIdentifier;
@@ -154,10 +158,10 @@ public override Task<Resource> ReplaceAsync(Resource resource, string correlatio
                 throw new HttpResponseException(HttpStatusCode.BadRequest);
             }
 
-            IEnumerable<Core2Group> exisitingGroups = this.storage.Groups.Values;
+            Core2Group exisitingGroups = resource as Core2Group;
             if
             (
-                exisitingGroups.Any(
+                this.storage.Groups.Values.Any(
                     (Core2Group exisitingUser) =>
                         string.Equals(exisitingUser.DisplayName, group.DisplayName, StringComparison.Ordinal) &&
                         !string.Equals(exisitingUser.Identifier, group.Identifier, StringComparison.OrdinalIgnoreCase))
@@ -171,6 +175,10 @@ public override Task<Resource> ReplaceAsync(Resource resource, string correlatio
                 throw new HttpResponseException(HttpStatusCode.NotFound);
             }
 
+            // Update metadata
+            group.Metadata.Created = exisitingGroups.Metadata.Created;
+            group.Metadata.LastModified = DateTime.UtcNow;
+
             this.storage.Groups[group.Identifier] = group;
             Resource result = group as Resource;
             return Task.FromResult(result);
@@ -241,6 +249,8 @@ public override Task UpdateAsync(IPatch patch, string correlationIdentifier)
             if (this.storage.Groups.TryGetValue(patch.ResourceIdentifier.Identifier, out Core2Group group))
             {
                 group.Apply(patchRequest);
+                // Update metadata
+                group.Metadata.LastModified = DateTime.UtcNow;
             }
             else
             {

Microsoft.SystemForCrossDomainIdentityManagement/Protocol/ProtocolExtensions.cs

@@ -1116,7 +1116,7 @@ internal static IEnumerable<Role> PatchRoles(IEnumerable<Role> roles, PatchOpera
             if
             (
                 !string.Equals(
-                    Microsoft.SCIM.AttributeNames.PhoneNumbers,
+                    Microsoft.SCIM.AttributeNames.Roles,
                     operation.Path.AttributePath,
                     StringComparison.OrdinalIgnoreCase)
             )
@@ -1156,10 +1156,10 @@ internal static IEnumerable<Role> PatchRoles(IEnumerable<Role> roles, PatchOpera
             }
 
             Role role;
-            Role roleAddressExisting;
+            Role roleExisting;
             if (roles != null)
             {
-                roleAddressExisting =
+                roleExisting =
                     role =
                         roles
                         .SingleOrDefault(
@@ -1168,7 +1168,7 @@ internal static IEnumerable<Role> PatchRoles(IEnumerable<Role> roles, PatchOpera
             }
             else
             {
-                roleAddressExisting = null;
+                roleExisting = null;
                 role =
                     new Role()
                     {
@@ -1191,7 +1191,7 @@ internal static IEnumerable<Role> PatchRoles(IEnumerable<Role> roles, PatchOpera
             IEnumerable<Role> result;
             if (string.IsNullOrWhiteSpace(role.Value))
             {
-                if (roleAddressExisting != null)
+                if (roleExisting != null)
                 {
                     result =
                         roles
@@ -1207,7 +1207,7 @@ internal static IEnumerable<Role> PatchRoles(IEnumerable<Role> roles, PatchOpera
                 return result;
             }
 
-            if (roleAddressExisting != null)
+            if (roleExisting != null)
             {
                 return roles;
             }