separated tests into Valid and Invalid.

Author: HP712

src/Microsoft.IdentityModel.Tokens.Saml/Saml/Experimental/SamlTokenUtilities.Experimental.cs

@@ -266,7 +266,7 @@ private static OperationResult<SecurityKey, ValidationError> ValidateSignatureUs
             CallContext callContext)
         {
             bool keysTried = false;
-            bool kidExists = !string.IsNullOrEmpty(signature?.KeyInfo?.Id);
+            bool kidExists = signature?.KeyInfo != null;
 
             IEnumerable<SecurityKey> keys = TokenUtilities.GetAllSigningKeys(configuration, validationParameters, callContext);
             StringBuilder exceptionStrings = null;
@@ -334,7 +334,7 @@ private static OperationResult<SecurityKey, ValidationError> ValidateSignatureUs
             {
                 return new SignatureValidationError(
                     new MessageDetail(
-                        Tokens.LogMessages.IDX10526,
+                        Tokens.LogMessages.IDX10524,
                         LogHelper.MarkAsNonPII(signature?.KeyInfo?.Id),
                         LogHelper.MarkAsNonPII(validationParameters.SigningKeys.Count),
                         LogHelper.MarkAsNonPII(configuration?.SigningKeys?.Count ?? 0),

test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateSignatureTests.cs

@@ -20,13 +20,13 @@
 namespace Microsoft.IdentityModel.JsonWebTokens.Tests
 {
     /// <summary>
-    /// These tests validate the decryption of JWE tokens using both TokenValidationParameters and ValidationParameters.
+    /// These tests validate the decryption of JWE's using both TokenValidationParameters and ValidationParameters.
     /// We want to make sure that they succeed or fail in the same way, and that the exceptions thrown are consistent.
-    /// ValidationParameters path specific tests are written in JsonWebTokenHandlerDecryptTokenTests.
+    /// ValidationParameters path specific tests are written in DecryptTokenTests.
     /// The tests in these files could be merged however it is presumed that the TokenValidationParameters will remain fixed while
     /// ValidationParameters scenarios will evolve in the future, so it was chosen to keep them separate.
     /// </summary>
-    public class JweDecryptionTests
+    public class JweDecryptionComparisonTests
     {
         [Theory, MemberData(nameof(InvalidDecryptionTestCases), DisableDiscoveryEnumeration = true)]
         public async Task InvalidDecryption(ValidateTokenTheoryData theoryData)