Skip to content

Commit e7b3b2e

Browse files
Fix errors in ESRP signing scripts (#38)
* Update windows ESRP signing script * Update mac ESRP signing scripts
1 parent 363137a commit e7b3b2e

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

bin/mac_esrp_signing/dll_signing.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
TENANT_ID = os.environ['TENANT_ID']
1515
KEY_CODE = os.environ['KEY_CODE']
1616

17-
esrp_tool = os.path.join("esrp", "tools", "EsrpClient.exe")
17+
esrp_tool = os.environ['ESRP_CLIENT']
1818
SOURCE = WORKSPACE / "osx-x64"
1919
DESTINATION = WORKSPACE
2020

2121
files = []
2222
extensions = [".dll"]
2323
for path in Path(SOURCE).iterdir():
24-
if path.suffix in extensions and path.is_file():
24+
if (path.name == "azureauth" or path.suffix in extensions) and path.is_file():
2525
files.append(path)
2626

2727
#empty list check
@@ -55,9 +55,9 @@
5555
"SignBatches": [
5656
{
5757
"SourceLocationType": "UNC",
58-
"SourceRootDirectory": SOURCE,
58+
"SourceRootDirectory": str(SOURCE),
5959
"DestinationLocationType": "UNC",
60-
"DestinationRootDirectory": DESTINATION,
60+
"DestinationRootDirectory": str(DESTINATION),
6161
"SignRequestFiles": [
6262
{
6363
"CustomerCorrelationId": "01A7F55F-6CDD-4123-B255-77E6F212CDAD",

bin/mac_esrp_signing/dylibs_signing.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@
1515
TENANT_ID = os.environ['TENANT_ID']
1616
KEY_CODE = os.environ['KEY_CODE']
1717

18-
esrp_tool = os.path.join("esrp", "tools", "EsrpClient.exe")
18+
esrp_tool = os.environ['ESRP_CLIENT']
1919
SOURCE = WORKSPACE / "osx-x64"
2020
DESTINATION = WORKSPACE / "Mac_signed"
2121

2222
zip_file = SOURCE / "mac_dylibs.zip"
23-
extensions = [".dylib",".a",".Cli"]
23+
extensions = [".dylib"]
2424

2525
# zipping the files
2626
with zipfile.ZipFile(zip_file, 'w', zipfile.ZIP_DEFLATED) as zip_obj:
2727
for path in Path(SOURCE).iterdir():
28-
if path.suffix in extensions and path.is_file():
28+
if (path.name == "azureauth" or path.suffix in extensions) and path.is_file():
2929
zip_obj.write(path, path.relative_to(SOURCE))
3030

3131
if not zip_file.exists():
@@ -56,9 +56,9 @@
5656
"SignBatches": [
5757
{
5858
"SourceLocationType": "UNC",
59-
"SourceRootDirectory": SOURCE,
59+
"SourceRootDirectory": str(SOURCE),
6060
"DestinationLocationType": "UNC",
61-
"DestinationRootDirectory": DESTINATION,
61+
"DestinationRootDirectory": str(DESTINATION),
6262
"SignRequestFiles": [
6363
{
6464
"CustomerCorrelationId": "01A7F55F-6CDD-4123-B255-77E6F212CDAD",

bin/run_esrp_signing.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
TENANT_ID = os.environ['TENANT_ID']
1515
KEY_CODE = os.environ['KEY_CODE']
1616

17-
esrp_tool = os.path.join("esrp", "tools", "EsrpClient.exe")
17+
esrp_tool = os.environ['ESRP_CLIENT']
1818
SOURCE = WORKSPACE / "win10-x64"
1919
DESTINATION = WORKSPACE
2020

@@ -54,9 +54,9 @@
5454
"SignBatches": [
5555
{
5656
"SourceLocationType": "UNC",
57-
"SourceRootDirectory": SOURCE,
57+
"SourceRootDirectory": str(SOURCE),
5858
"DestinationLocationType": "UNC",
59-
"DestinationRootDirectory": DESTINATION,
59+
"DestinationRootDirectory": str(DESTINATION),
6060
"SignRequestFiles": [
6161
{
6262
"CustomerCorrelationId": "01A7F55F-6CDD-4123-B255-77E6F212CDAD",

0 commit comments

Comments
 (0)