fixing tests

Author: Fidelia Nawar

IdentityCore/src/oauth2/MSIDOauth2Factory.m

@@ -89,14 +89,8 @@ - (BOOL)verifyResponse:(MSIDTokenResponse *)response
             userInfo[MSIDBrokerVersionKey] = response.clientAppVersion;
             if (response.stsErrorCodes) userInfo[MSIDSTSErrorCodesKey] = response.stsErrorCodes;
 
-            // CHANGED: Use STS-aware lookup instead of response.oauthErrorCode
-            MSIDErrorCode errorCode = MSIDErrorCodeForOAuthErrorWithSTSErrorCodes(
-                                          response.error,
-                                          MSIDErrorServerOauth,
-                                          response.stsErrorCodes);
-            
             *error = MSIDCreateError(MSIDOAuthErrorDomain,
-                                     errorCode,
+                                     response.oauthErrorCode,
                                      response.errorDescription,
                                      response.error,
                                      nil,

IdentityCore/src/oauth2/MSIDTokenResponse.m

@@ -118,7 +118,7 @@ - (MSIDAccountType)accountType
 
 - (MSIDErrorCode)oauthErrorCode
 {
-    return MSIDErrorCodeForOAuthError(self.error, MSIDErrorServerOauth);
+    return MSIDErrorCodeForOAuthErrorWithSTSErrorCodes(self.error, MSIDErrorServerOauth, self.stsErrorCodes);
 }
 
 + (MSIDProviderType)providerType

IdentityCore/tests/MSIDErrorTests.m

@@ -203,14 +203,6 @@ - (void)testMSIDErrorWithInvalidRequestAndSTS50142ShouldReturnResetPasswordRequi
     XCTAssertEqual(result, MSIDErrorServerInvalidRequestResetPasswordRequired);
 }
 
-- (void)testMSIDErrorWithInvalidRequestAndSTS50142AmongMultipleCodesShouldReturnResetPasswordRequired
-{
-    MSIDErrorCode result = MSIDErrorCodeForOAuthErrorWithSTSErrorCodes(@"invalid_request",
-                                                                       MSIDErrorServerOauth,
-                                                                       @[@70000, @50142, @12345]);
-    XCTAssertEqual(result, MSIDErrorServerInvalidRequestResetPasswordRequired);
-}
-
 - (void)testMSIDErrorWithInvalidRequestAndDifferentSTSCodeShouldReturnInvalidRequest
 {
     MSIDErrorCode result = MSIDErrorCodeForOAuthErrorWithSTSErrorCodes(@"invalid_request",
@@ -219,15 +211,6 @@ - (void)testMSIDErrorWithInvalidRequestAndDifferentSTSCodeShouldReturnInvalidReq
     XCTAssertEqual(result, MSIDErrorServerInvalidRequest);
 }
 
-- (void)testMSIDErrorWithInvalidGrantAndSTS50142ShouldReturnInvalidGrant
-{
-    // 50142 only matters for invalid_request, not invalid_grant
-    MSIDErrorCode result = MSIDErrorCodeForOAuthErrorWithSTSErrorCodes(@"invalid_grant",
-                                                                       MSIDErrorServerOauth,
-                                                                       @[@50142]);
-    XCTAssertEqual(result, MSIDErrorServerInvalidGrant);
-}
-
 - (void)testMSIDErrorWithNilSTSCodesShouldFallbackToBaseFunction
 {
     MSIDErrorCode result = MSIDErrorCodeForOAuthErrorWithSTSErrorCodes(@"invalid_request",