Merge pull request #644 from AzureAD/hotfix/build-ios-in-cpp-repo

Hotfix/build ios in cpp repo

Author: oldalton

IdentityCore/IdentityCore.xcodeproj/project.pbxproj

@@ -29,7 +29,7 @@ @interface AppDelegate ()
 
 @implementation AppDelegate
 
-- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
+- (BOOL)application:(__unused UIApplication *)application didFinishLaunchingWithOptions:(__unused NSDictionary *)launchOptions
 {
     return YES;
 }

IdentityCore/MSIDTestsHostApp/AppDelegate.m

@@ -584,7 +584,7 @@ - (BOOL)saveWipeInfoWithContext:(id<MSIDRequestContext>)context
 }
 
 - (NSDictionary *)wipeInfo:(id<MSIDRequestContext>)context
-                     error:(NSError **)error;
+                     error:(NSError **)error
 {
     NSMutableDictionary *query = [self.defaultWipeQuery mutableCopy];
     [query setObject:@YES forKey:(id)kSecReturnData];
@@ -677,7 +677,7 @@ - (MSIDCacheKey *)overrideTokenKey:(MSIDCacheKey *)key
     return key;
 }
 
-- (NSString *)extractAppKey:(NSString *)cacheKeyString
+- (NSString *)extractAppKey:(__unused NSString *)cacheKeyString
 {
     // no app key needs to be set here
     return nil;

IdentityCore/src/cache/MSIDKeychainTokenCache.m

@@ -645,8 +645,8 @@ - (MSIDCredentialCacheItem *)tokenWithKey:(MSIDCacheKey *)key
 }
 
 - (NSMutableArray<MSIDCredentialCacheItem *> *)filterTokenItemsFromKeychainItems:(NSArray *)items
-                                                                      serializer:(id<MSIDCacheItemSerializing>)serializer
-                                                                         context:(id<MSIDRequestContext>)context
+                                                                      serializer:(__unused id<MSIDCacheItemSerializing>)serializer
+                                                                         context:(__unused id<MSIDRequestContext>)context
 {
     NSMutableArray *tokenItems = [[NSMutableArray<MSIDCredentialCacheItem *> alloc] initWithCapacity:items.count];
 
@@ -685,7 +685,7 @@ - (MSIDCredentialCacheItem *)tokenWithKey:(MSIDCacheKey *)key
  */
 - (BOOL)removeAllMatchingTokens:(MSIDCacheKey *)key
                         context:(id<MSIDRequestContext>)context
-                     serializer:(id<MSIDCacheItemSerializing>)serializer
+                     serializer:(__unused id<MSIDCacheItemSerializing>)serializer
                        isShared:(BOOL)isShared
                           error:(NSError * _Nullable * _Nullable)error
 {
@@ -889,7 +889,7 @@ - (BOOL)removeItemsWithKey:(MSIDCacheKey *)key
     return [self removeStorageItem:key.isShared context:context error:error];
 }
 
-- (NSDictionary *)primaryAttributesForItem:(BOOL)isShared context:(id<MSIDRequestContext>)context error:(NSError **)error
+- (NSDictionary *)primaryAttributesForItem:(BOOL)isShared context:(__unused id<MSIDRequestContext>)context error:(__unused NSError **)error
 {
     NSMutableDictionary *attributes = [NSMutableDictionary dictionary];
 

IdentityCore/src/cache/mac/MSIDMacKeychainTokenCache.m

@@ -65,7 +65,7 @@ - (void)willAccessCache:(nonnull MSIDMacTokenCache *)cache
     [self readAndDeserializeWithCache:cache];
 }
 
-- (void)didAccessCache:(nonnull MSIDMacTokenCache *)cache
+- (void)didAccessCache:(nonnull __unused MSIDMacTokenCache *)cache
 {
 
 }

IdentityCore/src/cache/mac/MSIDMacLegacyCachePersistenceHandler.m

@@ -346,7 +346,7 @@ + (void)startTrackingAppState
 
 #if !AD_BROKER
 
-+ (void)appEnteredForeground:(NSNotification *)notification
++ (void)appEnteredForeground:(__unused NSNotification *)notification
 {
     [[NSNotificationCenter defaultCenter] removeObserver:self
                                                     name:UIApplicationWillEnterForegroundNotification
@@ -360,7 +360,7 @@ + (void)appEnteredForeground:(NSNotification *)notification
                                                  name:UIApplicationDidBecomeActiveNotification object:nil];
 }
 
-+ (void)checkTokenResponse:(NSNotification *)notification
++ (void)checkTokenResponse:(__unused NSNotification *)notification
 {
     [[NSNotificationCenter defaultCenter] removeObserver:self
                                                     name:UIApplicationDidBecomeActiveNotification

IdentityCore/src/controllers/ios/MSIDBrokerInteractiveController.m

@@ -27,7 +27,7 @@
 
 @implementation MSIDIntuneApplicationStateManager
 
-+ (BOOL)isAppCapableForMAMCA:(MSIDAuthority *)authority
++ (BOOL)isAppCapableForMAMCA:(__unused MSIDAuthority *)authority
 {
 #if TARGET_OS_IPHONE
 

IdentityCore/src/intune/MSIDIntuneApplicationStateManager.m

@@ -42,7 +42,7 @@
 @implementation MSIDLegacyBrokerResponseHandler
 
 - (id<MSIDCacheAccessor>)cacheAccessorWithKeychainGroup:(__unused NSString *)keychainGroup
-                                                  error:(NSError **)error
+                                                  error:(__unused NSError **)error
 {
 #if TARGET_OS_IPHONE
     MSIDKeychainTokenCache *dataSource = [[MSIDKeychainTokenCache alloc] initWithGroup:keychainGroup error:error];

IdentityCore/src/requests/sdk/adal/MSIDLegacyBrokerResponseHandler.m

@@ -194,7 +194,7 @@ + (void)cancelCurrentSession
 #endif
 
 #if TARGET_OS_IPHONE && !MSID_EXCLUDE_SYSTEMWV
-+ (BOOL)handleURLResponseForSystemWebviewController:(NSURL *)url;
++ (BOOL)handleURLResponseForSystemWebviewController:(NSURL *)url
 {
     @synchronized([MSIDWebviewAuthorization class])
     {

IdentityCore/src/webview/MSIDWebviewAuthorization.m

@@ -33,12 +33,12 @@ + (void)handleChallenge:(NSURLAuthenticationChallenge *)challenge
                 webview:(WKWebView *)webview
        parentController:(UIViewController *)parentViewController
                 context:(id<MSIDRequestContext>)context
-      completionHandler:(ChallengeCompletionHandler)completionHandler;
+      completionHandler:(ChallengeCompletionHandler)completionHandler
 #else
 + (void)handleChallenge:(NSURLAuthenticationChallenge *)challenge
                 webview:(WKWebView *)webview
                 context:(id<MSIDRequestContext>)context
-      completionHandler:(ChallengeCompletionHandler)completionHandler;
+      completionHandler:(ChallengeCompletionHandler)completionHandler
 #endif
 {
     NSString *authMethod = [challenge.protectionSpace.authenticationMethod lowercaseString];