Merge pull request #1494 from AzureAD/mipetriu/spinner_fix

Loading spinner fix - check if webview navigation action targeted to main frame

Author: mipetriu

IdentityCore/src/webview/embeddedWebview/MSIDOAuth2EmbeddedWebviewController.m

@@ -280,7 +280,7 @@ - (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigati
 
     MSID_LOG_WITH_CTX_PII(MSIDLogLevelVerbose, self.context, @"-decidePolicyForNavigationAction host: %@", MSID_PII_LOG_TRACKABLE(requestURL.host));
 
-    if ([self shouldSendNavigationNotification:requestURL])
+    if ([self shouldSendNavigationNotification:requestURL navigationAction:navigationAction])
     {
         [MSIDNotifications notifyWebAuthDidStartLoad:requestURL userInfo:webView ? @{@"webview" : webView} : nil];
     }
@@ -550,14 +550,19 @@ - (void)notifyFinishedNavigation:(NSURL *)url webView:(WKWebView *)webView
     [self stopSpinner];
 }
 
-- (BOOL)shouldSendNavigationNotification:(NSURL *)requestURL
+- (BOOL)shouldSendNavigationNotification:(NSURL *)requestURL navigationAction:(WKNavigationAction *)navigationAction
 {
     NSString *requestURLString = [requestURL.absoluteString lowercaseString];
     if ([requestURLString isEqualToString:@"about:blank"] || [requestURLString isEqualToString:@"about:srcdoc"])
     {
         return NO;
     }
 
+    if (!navigationAction.targetFrame.isMainFrame)
+    {
+        return NO;
+    }
+    
     return YES;
 }