Merge pull request #612 from AzureAD/oldalton/improve_error_logging

Improve error logging when creating claims

Author: oldalton

IdentityCore/src/oauth2/aad_v1/MSIDAADV1IdTokenClaims.m

@@ -92,6 +92,12 @@ - (void)initDerivedProperties
 
     _userId = [MSIDHelpers normalizeUserId:_userId];
 
+    if (!self.issuer)
+    {
+        MSID_LOG_WITH_CTX(MSIDLogLevelInfo, nil, @"Issuer is not present in the provided AAD v1 id token claims");
+        return;
+    }
+    
     NSError *issuerError = nil;
     _issuerAuthority = [[MSIDAADAuthority alloc] initWithURL:[NSURL URLWithString:self.issuer] rawTenant:nil context:nil error:&issuerError];
 

IdentityCore/src/oauth2/aad_v2/MSIDAADV2IdTokenClaims.m

@@ -65,6 +65,12 @@ - (void)initDerivedProperties
     _userId = [MSIDHelpers normalizeUserId:userId];
     _userIdDisplayable = YES;
 
+    if (!self.issuer)
+    {
+        MSID_LOG_WITH_CTX(MSIDLogLevelInfo, nil, @"Issuer is not present in the provided AAD v2 id token claims");
+        return;
+    }
+    
     NSError *issuerError = nil;
     _issuerAuthority = [[MSIDAADAuthority alloc] initWithURL:[NSURL URLWithString:self.issuer] rawTenant:nil context:nil error:&issuerError];
 

IdentityCore/src/oauth2/b2c/MSIDB2CIdTokenClaims.m

@@ -52,6 +52,12 @@ - (void)initDerivedProperties
 
     _userId = [MSIDHelpers normalizeUserId:userId];
 
+    if (!self.issuer)
+    {
+        MSID_LOG_WITH_CTX(MSIDLogLevelInfo, nil, @"Issuer is not present in the provided B2C id token claims");
+        return;
+    }
+    
     NSError *issuerError = nil;
     _issuerAuthority = [[MSIDB2CAuthority alloc] initWithURL:[NSURL URLWithString:self.issuer] validateFormat:NO context:nil error:&issuerError];