Skip to content

Commit 6a229d7

Browse files
committed
Merge branch 'jarias/use-single-frt-2' into jarias/test-fix-msalcpp-pipeline
2 parents 7ddad13 + e77d1a2 commit 6a229d7

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

IdentityCore/src/cache/accessor/MSIDDefaultTokenCacheAccessor.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,14 @@ - (MSIDRefreshToken *)getRefreshTokenWithAccount:(MSIDAccountIdentifier *)accoun
141141
MSID_LOG_WITH_CTX(MSIDLogLevelError, context, @"Error checking FRT enabled status, not using new FRT. Error: %@", frtError);
142142
}
143143

144+
#if !EXCLUDE_FROM_MSALCPP
144145
MSIDAADTokenRequestServerTelemetry *serverTelemetry = [MSIDAADTokenRequestServerTelemetry new];
145146
NSString *telemetryMessage = [NSString stringWithFormat:@"sfrt(%ld)", frtStatus];
146147

147148
[serverTelemetry handleError:[[NSError alloc] initWithDomain:telemetryMessage code:0 userInfo:nil]
148149
errorString:telemetryMessage
149150
context:context];
151+
#endif
150152

151153
MSIDCredentialType credentialType = frtEnabled ? MSIDFamilyRefreshTokenType : MSIDRefreshTokenType;
152154

IdentityCore/src/requests/MSIDInteractiveTokenRequest.m

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,16 +149,19 @@ - (void)updateCustomHeadersForFRTSupportIfNeeded
149149
{
150150
NSError *error = nil;
151151
MSIDIsFRTEnabledStatus frtEnabledStatus = [credentialCache checkFRTEnabled:self.requestParameters error:&error];
152+
enableFRT = (frtEnabledStatus == MSIDIsFRTEnabledStatusEnabled);
152153

153-
if (!error)
154+
if (error)
154155
{
155156
MSID_LOG_WITH_CTX(MSIDLogLevelError, self.requestParameters, @"Error when checking if FRT is enabled: error code: %@", error);
156-
enableFRT = (frtEnabledStatus == MSIDIsFRTEnabledStatusEnabled);
157157
}
158158
}
159159
}
160160

161-
if (self.requestParameters.promptType != MSIDPromptTypeLogin && enableFRT)
161+
if (enableFRT &&
162+
self.requestParameters.promptType != MSIDPromptTypeLogin &&
163+
self.requestParameters.promptType != MSIDPromptTypeSelectAccount &&
164+
self.requestParameters.promptType != MSIDPromptTypeCreate)
162165
{
163166
NSMutableDictionary *customHeaders = nil;
164167
if (self.requestParameters.customWebviewHeaders)

0 commit comments

Comments
 (0)