Merge pull request #1549 from AzureAD/swagup/fixAppInfoBroserNativeSSO

Fix AppInfo for Edge Native MSALJS Native Bridge Brower SSO Flow

Author: swasti29

IdentityCore/src/broker_operation/request/browser_native_message_request/MSIDBrokerOperationBrowserNativeMessageRequest.m

@@ -61,17 +61,17 @@ + (NSString *)operation
 
 - (NSString *)callerBundleIdentifier
 {
-    return self.parentProcessBundleIdentifier ?: NSLocalizedString(@"N/A", nil);
+    return self.parentProcessBundleIdentifier ?: @"";
 }
 
 - (NSString *)callerTeamIdentifier
 {
-    return self.parentProcessTeamId ?: NSLocalizedString(@"N/A", nil);
+    return self.parentProcessTeamId ?: @"";
 }
 
 - (NSString *)localizedCallerDisplayName
 {
-    return self.parentProcessLocalizedName ?: NSLocalizedString(@"N/A", nil);
+    return self.parentProcessLocalizedName ?: @"";
 }
 
 - (NSString *)localizedApplicationInfo
@@ -87,7 +87,7 @@ - (NSString *)localizedApplicationInfo
         return brokerOperationRequest.localizedApplicationInfo;
     }
 
-    return NSLocalizedString(@"N/A", nil);
+    return @"";
 }
 
 #pragma mark - MSIDJsonSerializable

IdentityCore/tests/MSIDBrokerOperationBrowserNativeMessageRequestTests.m

@@ -143,7 +143,7 @@ - (void)testInitWithJSONDictionary_whenAllValuesSet_shoudlInit
     XCTAssertEqualObjects(request.localizedApplicationInfo, @"mock_app_info");
 }
 
-- (void)testInitWithJSONDictionary_whenNoParentProcessInfo_shouldReturnNA
+- (void)testInitWithJSONDictionary_whenNoParentProcessInfo_shouldReturnEmptyValues
 {
     __auto_type json = @{@"broker_key": @"some key",
                          @"msg_protocol_ver": @"1",
@@ -156,10 +156,10 @@ - (void)testInitWithJSONDictionary_whenNoParentProcessInfo_shouldReturnNA
     XCTAssertEqualObjects(request.brokerKey, @"some key");
     XCTAssertEqual(request.protocolVersion, 1);
     XCTAssertEqualObjects(request.payloadJson, @{@"method":@"GetCookies"});
-    XCTAssertEqualObjects(request.callerBundleIdentifier, @"N/A");
-    XCTAssertEqualObjects(request.callerTeamIdentifier, @"N/A");
-    XCTAssertEqualObjects(request.localizedCallerDisplayName, @"N/A");
-    XCTAssertEqualObjects(request.localizedApplicationInfo, @"N/A");
+    XCTAssertEqualObjects(request.callerBundleIdentifier, @"");
+    XCTAssertEqualObjects(request.callerTeamIdentifier, @"");
+    XCTAssertEqualObjects(request.localizedCallerDisplayName, @"");
+    XCTAssertEqualObjects(request.localizedApplicationInfo, @"");
     XCTAssertNil(request.parentProcessBundleIdentifier);
     XCTAssertNil(request.parentProcessTeamId);
     XCTAssertNil(request.parentProcessLocalizedName);