Skip to content

Commit 778e0f0

Browse files
committed
Address comments
1 parent 30a83ef commit 778e0f0

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

IdentityCore/src/oauth2/token/MSIDBoundRefreshToken+Redemption.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ NS_ASSUME_NONNULL_BEGIN
3737
- (NSString *) getTokenRedemptionJwtForTenantId: (nullable NSString *)tenantId
3838
tokenRedemptionParameters: (MSIDBoundRefreshTokenRedemptionParameters *)requestParameters
3939
context:(id<MSIDRequestContext> _Nullable)context
40-
jweCrypto: (NSDictionary * __nonnull __autoreleasing *__nonnull)jweCrypto
41-
error: (NSError * __autoreleasing *)error;
40+
jweCrypto: (NSDictionary *__nonnull *__nonnull)jweCrypto
41+
error: (NSError *__nonnull __autoreleasing *__nonnull)error;
4242
@end
4343
NS_ASSUME_NONNULL_END

IdentityCore/src/oauth2/token/MSIDBoundRefreshToken+Redemption.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ @implementation MSIDBoundRefreshToken (Redemption)
3939
- (NSString *)getTokenRedemptionJwtForTenantId:(nullable NSString *)tenantId
4040
tokenRedemptionParameters:(MSIDBoundRefreshTokenRedemptionParameters *) requestParameters
4141
context:(id<MSIDRequestContext> _Nullable)context
42-
jweCrypto:(NSDictionary * __autoreleasing __nonnull *__nonnull)jweCrypto
43-
error:(NSError *__autoreleasing _Nullable * _Nullable)error
42+
jweCrypto:(NSDictionary * __autoreleasing *)jweCrypto
43+
error:(NSError * __autoreleasing *)error
4444
{
4545
if (![self validateRequestParameters:requestParameters context:context error:error])
4646
{
@@ -67,7 +67,7 @@ - (NSString *)getTokenRedemptionJwtForTenantId:(nullable NSString *)tenantId
6767
error:error];
6868
if (!ecdhPartyVInfoData)
6969
{
70-
MSID_LOG_WITH_CTX(MSIDLogLevelError, context, @"[Bound Refresh token redemption] Failed to create ECDH APV data for bound RT redemption JWT.");
70+
MSID_LOG_WITH_CTX(MSIDLogLevelError, context, @"Failed to create ECDH APV data for bound RT redemption JWT..");
7171
if (error)
7272
*error = [self createErrorWithDomain:MSIDErrorDomain
7373
code:MSIDErrorInvalidInternalParameter

IdentityCore/src/parameters/MSIDBoundRefreshTokenRedemptionParameters.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@ - (nonnull NSMutableDictionary *)jsonDictionary
7979
jsonDict[@"nbf"] = @((long)now); // Not before time
8080
[jsonDict setObject:self.clientId forKey:MSID_OAUTH2_CLIENT_ID];
8181
if (![NSString msidIsStringNilOrBlank:self.nonce])
82+
{
8283
[jsonDict setObject:self.nonce forKey:@"nonce"];
84+
}
8385
NSString *scopeString = [self.scopes.allObjects componentsJoinedByString:@" "];
8486
[jsonDict setObject:scopeString forKey:MSID_OAUTH2_SCOPE];
8587
return jsonDict;

0 commit comments

Comments
 (0)