Improvements

Author: josephpab

IdentityCore/src/webview/response/MSIDSwitchBrowserResponse.m

@@ -27,6 +27,7 @@
 #import "MSIDWebResponseOperationFactory.h"
 #import "MSIDConstants.h"
 #import "MSIDFlightManager.h"
+#import "NSData+MSIDExtensions.h"
 
 @implementation MSIDSwitchBrowserResponse
 
@@ -54,9 +55,7 @@ - (instancetype)initWithURL:(NSURL *)url
         NSString* browserOptionsString = self.parameters[@"browser_modes"];
         if (browserOptionsString)
         {
-            browserOptionsString = Base64URLToStandardBase64(browserOptionsString);
-            NSData *data = [[NSData alloc] initWithBase64EncodedString:browserOptionsString options:0];
-
+            NSData *data = [NSData msidDataFromBase64UrlEncodedString:browserOptionsString];
             uint32_t flagsValue = 0;
             [data getBytes:&flagsValue length:sizeof(flagsValue)];
 

IdentityCore/tests/MSIDSwitchBrowserResponseTest.swift

@@ -82,7 +82,7 @@ final class MSIDSwitchBrowserResponseTest: XCTestCase
         XCTAssertEqual(response?.switchBrowserSessionToken, "some_code")
     }
 
-    func testInit_whenValidBrowserMode_shouldCreateObject() throws
+    func testInit_whenValidBrowserMode_hasBitmaskPrivateSessionShouldBeTrue() throws
     {
         let url = URL(string: "msauth://broker_bundle_id//switch_browser?action_uri=some_uri&code=some_code&browser_modes=AAAAAQ")!
 
@@ -95,7 +95,7 @@ final class MSIDSwitchBrowserResponseTest: XCTestCase
         XCTAssertEqual(response?.bitMask, 1)
     }
 
-    func testInit_whenInvalidBrowserMode_hasBitmaskShouldBeFalse() throws
+    func testInit_whenInvalidBrowserMode_hasBitmaskPrivateSessionShouldBeFalse() throws
     {
         let url = URL(string: "msauth://broker_bundle_id//switch_browser?action_uri=some_uri&code=some_code&browser_modes=AAAAAA")!