update the error name

Author: Veena11

IdentityCore/src/MSIDError.h

@@ -172,7 +172,7 @@ typedef NS_ENUM(NSInteger, MSIDErrorCode)
 
     MSIDErrorServerUnhandledResponse    = -51500,
     // http status Code 403 or 404
-    MSIDErrorUnExpectedHttpResponse     = -51501,
+    MSIDErrorUnexpectedHttpResponse     = -51501,
 
     /*!
      =========================================================

IdentityCore/src/MSIDError.m

@@ -225,7 +225,7 @@ MSIDErrorCode MSIDErrorCodeForOAuthErrorWithSubErrorCode(NSString *oauthError, M
                       ],
               MSIDHttpErrorCodeDomain : @[
                       @(MSIDErrorServerUnhandledResponse),
-                      @(MSIDErrorUnExpectedHttpResponse)
+                      @(MSIDErrorUnexpectedHttpResponse)
                       ]
 
               // TODO: add new codes here
@@ -302,8 +302,8 @@ void MSIDFillAndLogError(NSError **error, MSIDErrorCode errorCode, NSString *err
             // HTTP errors
         case MSIDErrorServerUnhandledResponse:
             return @"MSIDErrorServerUnhandledResponse";
-        case MSIDErrorUnExpectedHttpResponse:
-            return @"MSIDErrorUnExpectedHttpResponse";
+        case MSIDErrorUnexpectedHttpResponse:
+            return @"MSIDErrorUnexpectedHttpResponse";
             // Authority validation errors
         case MSIDErrorAuthorityValidation:
             return @"MSIDErrorAuthorityValidation";

IdentityCore/src/network/error_handler/MSIDAADRequestErrorHandler.m

@@ -153,7 +153,7 @@ - (void)handleError:(NSError *)error
     NSError *httpUnderlyingError = nil;
     if (httpResponse.statusCode == 403 || httpResponse.statusCode == 404)
     {
-        httpUnderlyingError = MSIDCreateError(MSIDHttpErrorCodeDomain, MSIDErrorUnExpectedHttpResponse, errorDescription, nil, nil, nil, context.correlationId, nil, YES);
+        httpUnderlyingError = MSIDCreateError(MSIDHttpErrorCodeDomain, MSIDErrorUnexpectedHttpResponse, errorDescription, nil, nil, nil, context.correlationId, nil, YES);
     }
 
     NSError *httpError = MSIDCreateError(MSIDHttpErrorCodeDomain, MSIDErrorServerUnhandledResponse, errorDescription, nil, nil, httpUnderlyingError, context.correlationId, additionalInfo, YES);

IdentityCore/tests/MSIDAADRequestErrorHandlerTests.m

@@ -192,7 +192,7 @@ - (void)testHandleError_whenItIsNotServerError_shouldReturnStatusCodeAndHeaders
     XCTAssertEqualObjects(returnError.domain, MSIDHttpErrorCodeDomain);
     XCTAssertEqual(returnError.code, MSIDErrorServerUnhandledResponse);
     NSError *underlyingError = returnError.userInfo[NSUnderlyingErrorKey];
-    XCTAssertEqual(underlyingError.code, MSIDErrorUnExpectedHttpResponse);
+    XCTAssertEqual(underlyingError.code, MSIDErrorUnexpectedHttpResponse);
     XCTAssertEqualObjects(returnError.userInfo[MSIDHTTPHeadersKey], @{@"headerKey":@"headerValue"});
 
     XCTAssertNil(errorResponse);
@@ -278,7 +278,7 @@ - (void)testHandleError_whenItIsServerError_shouldReturnResponseCodeInError
     XCTAssertEqualObjects(returnError.domain, MSIDHttpErrorCodeDomain);
     XCTAssertEqual(returnError.code, MSIDErrorServerUnhandledResponse);
     NSError *underlyingError = returnError.userInfo[NSUnderlyingErrorKey];
-    XCTAssertEqual(underlyingError.code, MSIDErrorUnExpectedHttpResponse);
+    XCTAssertEqual(underlyingError.code, MSIDErrorUnexpectedHttpResponse);
     XCTAssertEqualObjects(returnError.userInfo[MSIDHTTPResponseCodeKey], @"404");
 }
 

IdentityCore/tests/integration/ios/MSIDDefaultSilentTokenRequestTests.m

@@ -1389,6 +1389,8 @@ - (void)testAcquireTokenSilent_when403HttpCodeReturned_shouldReturnMSIDErrorUnex
         XCTAssertNotNil(error);
         XCTAssertNil(result);
         XCTAssertEqual(error.code, MSIDErrorServerUnhandledResponse);
+        NSError *underlyingError = error.userInfo[NSUnderlyingErrorKey];
+        XCTAssertEqual(underlyingError.code, MSIDErrorUnexpectedHttpResponse);
         XCTAssertEqualObjects(error.domain, MSIDHttpErrorCodeDomain);
         XCTAssertEqualObjects(error.userInfo[MSIDHTTPResponseCodeKey], @"403");
         [expectation fulfill];