Updating testDeviceCodeFlowTokenExpiredToken unit test, Fixes AB#3468472 #2427
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the testDeviceCodeFlowTokenExpiredToken unit test by replacing an expired device code token with a new one to ensure the test continues to function correctly.
Key Changes:
- Updated the device code token used in the expired token test case
- Updated the common subproject commit reference
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| msal/src/test/java/com/microsoft/identity/client/e2e/tests/mocked/DeviceCodeFlowApiTest.java | Replaced expired device code token with a new token value |
| common | Updated subproject commit reference |
|
Thanks |
| tokenRequest.setDeviceCode( | ||
| "BAQABIQEAAADnfolhJpSnRYB1SVj-Hgd8CWNtqmssVukUXfdCHy1XJMxy2O7R0WZgTVcQVF4A3fjnWPQ1JPXf-" | ||
| + "SIl-NLuC9gGzGRgsLyUyknjbUReNC7vcHx8jigGiO2CkKi_Mc_YRU0E0lGH3EQZiJNwHxUc_YkTGG5DKl9sww36TdMPz-v7Bzy6cHzR6r3yQWULGNtidaogAA"); | ||
| "EAQABIQEAAABlMNzVhAPUTrARzfQjWPtKRXZvU3RzQXJ0aWZhY3RzAQAAAAAAPYh9V3CvjvOB825bqyY61Bde3S6FzapbES5Yr5kuUdO4amvrqBW9JTaXBUIH9PMoK7yFKza-nSqRHL0yoxYNHhkg0f1_juE50MlJSvdXBWJEsHHZk2y2T5804dMx1QZX0739imnhE0Y9Lm1Wd5iFbaTQZrcD9oKgxxKRL8GavO4gAA"); |
There was a problem hiding this comment.
Good to include instruction or comment how to handle in case of failure, especially inputs on generating new device code? can be helpful in future,
There was a problem hiding this comment.
I'll put some instructions here: I used debug msalTestApp to run DCF with a breakpoint here, and from that breakpoint, I took the device code value. I think it took about 30 ish min to expire.
Some folks are also wondering if maybe this test isn't needed anymore. @fadidurah can you evaluate this when you get back?
This test has been failing again with invalid_grant; this is because the expired device code value we used is now "expired" (server side not recognizing it as a previous code anymore). So we need to update this value.
Also updating common submodule while I'm at it.
AB#3468472