Fix more tests

Author: bgavrilMS

src/client/Microsoft.Identity.Client/Internal/Broker/BrokerInteractiveRequestComponent.cs

@@ -93,7 +93,6 @@ public async Task<MsalTokenResponse> FetchTokensAsync(CancellationToken cancella
         public static bool IsBrokerRequiredAuthCode(string authCode, out string installationUri)
         {
             if (authCode.StartsWith(BrokerParameter.AuthCodePrefixForEmbeddedWebviewBrokerInstallRequired, StringComparison.OrdinalIgnoreCase))
-            //|| authCode.StartsWith(_serviceBundle.Config.RedirectUri, StringComparison.OrdinalIgnoreCase) // TODO: what is this?!
             {
                 installationUri = ExtractAppLink(authCode);
                 return (installationUri != null);

src/client/Microsoft.Identity.Client/Internal/Requests/DeviceCodeRequest.cs

@@ -89,7 +89,7 @@ private async Task<MsalTokenResponse> WaitForTokenResponseAsync(
                 }
                 catch (MsalServiceException ex)
                 {
-                    // TODO: handle 429 concerns here and back off farther if needed.
+                    // TODO: handle 429 concerns here and back off further if needed.
                     if (ex.ErrorCode.Equals(OAuth2Error.AuthorizationPending, StringComparison.OrdinalIgnoreCase))
                     {
                         await Task.Delay(TimeSpan.FromSeconds(deviceCodeResult.Interval), cancellationToken)

tests/CacheCompat/CommonCache.Test.Unit/CacheExecutionTests.cs

@@ -31,7 +31,6 @@ private static async Task<LabUserData> GetPublicAadUserDataAsync()
         [AssemblyInitialize]
         public static void AssemblyInit(TestContext testContext)
         {
-            // TODO: add other users to the mix
             s_labUsers.Add(GetPublicAadUserDataAsync().GetAwaiter().GetResult());
         }
 

tests/Microsoft.Identity.Test.Unit/CacheTests/CacheSerializationTests.cs

@@ -258,7 +258,7 @@ public void TestSerializeMsalAccessTokenCacheItem_WithRefreshOn()
             string asJson = item.ToJsonString();
             var item2 = MsalAccessTokenCacheItem.FromJsonString(asJson);
 
-            AssertAccessTokenCacheItemsAreEqual(item, item2, "123"); // TODO: fix this
+            AssertAccessTokenCacheItemsAreEqual(item, item2, "123"); 
         }
 
         [TestMethod]

tests/Microsoft.Identity.Test.Unit/CoreTests/WsTrustTests/MexParserTests.cs

@@ -49,7 +49,6 @@ public void WsTrust2005AddressExtractionTest()
         [Description("Mex endpoint fails to resolve")]
         public async Task MexEndpointFailsToResolveTestAsync()
         {
-            // TODO: should we move this into a separate test class for WsTrustWebRequestManager?
             using (var harness = CreateTestHarness())
             {
                 harness.HttpManager.AddMockHandlerContentNotFound(HttpMethod.Get);

tests/Microsoft.Identity.Test.Unit/Kerberos/KerberosSupplementalTicketManagerTests.cs

@@ -7,31 +7,32 @@
 using System.Linq;
 using System.Reflection;
 using System.Text;
+using System.Text.Json.Nodes;
 using System.Threading.Tasks;
 using Microsoft.Identity.Client;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using NSubstitute;
-//TODO bogavril - fix this test
+
 namespace Microsoft.Identity.Test.Unit.UtilTests
 {
-    //[TestClass]
-    //public class LinkerTests
-    //{
-    //    [TestMethod]
-    //    public void JsonObjectsArePreserved()
-    //    {
-    //        const string Message = "Please add a [Preserve(AllMembers=true)] attribute to each serializable object to avoid the Xamarin Linker removing this type. Type missing this: ";
-    //        var serializableTypes = typeof(PublicClientApplication).Assembly.GetTypes()
-    //            .Where(
-    //                t => t.GetCustomAttributes(typeof(JsonObjectAttribute), true).Any());
+    [TestClass]
+    public class LinkerTests
+    {
+        [TestMethod]
+        public void JsonObjectsArePreserved()
+        {
+            const string Message = "Please add a [Preserve(AllMembers=true)] attribute to each serializable object to avoid the Xamarin Linker removing this type. Type missing this: ";
+            var serializableTypes = typeof(PublicClientApplication).Assembly.GetTypes()
+                .Where(
+                    t => t.GetCustomAttributes(typeof(JsonObject), true).Any());
 
-    //        foreach (var serializableType in serializableTypes)
-    //        {
-    //            var preserveAttribute = serializableType.GetCustomAttribute<PreserveAttribute>();
-    //            Assert.IsNotNull(preserveAttribute, Message + serializableType);
-    //            Assert.IsTrue(preserveAttribute.AllMembers, Message + serializableType);
-    //        }
-    //    }
-    //}
+            foreach (var serializableType in serializableTypes)
+            {
+                var preserveAttribute = serializableType.GetCustomAttribute<PreserveAttribute>();
+                Assert.IsNotNull(preserveAttribute, Message + serializableType);
+                Assert.IsTrue(preserveAttribute.AllMembers, Message + serializableType);
+            }
+        }
+    }
 }
 #endif