Remove Azure VM, Function App and ARC tests from Integration tests and MSI Helper Service (#5294)

* Update ManagedIdentityTests.NetFwk.cs

* Update ManagedIdentityTests.NetFwk.cs

* helper

* authority

---------

Co-authored-by: Gladwin Johnson <[email protected]>

Author: gladjohn

tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/ManagedIdentityTests.NetFwk.cs

@@ -62,20 +62,9 @@ public class ManagedIdentityTests
 
         [DataTestMethod]
         [DataRow(MsiAzureResource.WebApp, "", DisplayName = "System_Identity_Web_App")]
-        //[DataRow(MsiAzureResource.Function, "", DisplayName = "System_Identity_Function_App")]
-        //[DataRow(MsiAzureResource.VM, "", DisplayName = "System_Identity_Virtual_Machine")]
         [DataRow(MsiAzureResource.WebApp, UserAssignedClientID, UserAssignedIdentityId.ClientId, DisplayName = "ClientId_Web_App")]
-        //[DataRow(MsiAzureResource.Function, UserAssignedClientID, UserAssignedIdentityId.ClientId, DisplayName = "ClientId_Function_App")]
-        //[DataRow(MsiAzureResource.VM, UserAssignedClientID, UserAssignedIdentityId.ClientId, DisplayName = "ClientId_Virtual_Machine")]
         [DataRow(MsiAzureResource.WebApp, UamiResourceId, UserAssignedIdentityId.ResourceId, DisplayName = "ResourceID_Web_App")]
-        //[DataRow(MsiAzureResource.Function, UamiResourceId, UserAssignedIdentityId.ResourceId, DisplayName = "ResourceID_Function_App")]
-        //[DataRow(MsiAzureResource.VM, UamiResourceId, UserAssignedIdentityId.ResourceId, DisplayName = "ResourceID_Virtual_Machine")]
         [DataRow(MsiAzureResource.WebApp, UserAssignedObjectID, UserAssignedIdentityId.ObjectId, DisplayName = "ObjectID_Web_App")]
-        //[DataRow(MsiAzureResource.Function, UserAssignedObjectID, UserAssignedIdentityId.ObjectId, DisplayName = "ObjectID_Function_App")]
-        //[DataRow(MsiAzureResource.VM, UserAssignedObjectID, UserAssignedIdentityId.ObjectId, DisplayName = "ObjectID_Virtual_Machine")]
-#if ENABLE_AZURE_ARC_TESTS
-        [DataRow(MsiAzureResource.AzureArc, "", DisplayName = "Azure_ARC")]
-#endif
         public async Task AcquireMSITokenAsync(MsiAzureResource azureResource, string userIdentity, UserAssignedIdentityId userAssignedIdentityId = UserAssignedIdentityId.None)
         {
             //Arrange
@@ -289,12 +278,6 @@ public async Task AcquireMsiToken_ExchangeForEstsToken_Successfully()
         [DataRow(MsiAzureResource.WebApp, SomeRandomGuid, UserAssignedIdentityId.ClientId, DisplayName = "ClientId_Web_App")]
         [DataRow(MsiAzureResource.WebApp, SomeRandomGuid, UserAssignedIdentityId.ObjectId, DisplayName = "ObjectId_Web_App")]
         [DataRow(MsiAzureResource.WebApp, Non_Existent_UamiResourceId, UserAssignedIdentityId.ResourceId, DisplayName = "ResourceID_Web_App")]
-        //[DataRow(MsiAzureResource.Function, SomeRandomGuid, UserAssignedIdentityId.ClientId, DisplayName = "ClientId_Function_App")]
-        //[DataRow(MsiAzureResource.Function, SomeRandomGuid, UserAssignedIdentityId.ObjectId, DisplayName = "ObjectId_Function_App")]
-        //[DataRow(MsiAzureResource.Function, Non_Existent_UamiResourceId, UserAssignedIdentityId.ResourceId, DisplayName = "ResourceID_Function_App")]
-        //[DataRow(MsiAzureResource.VM, SomeRandomGuid, UserAssignedIdentityId.ClientId, DisplayName = "ClientId_VM")]
-        //[DataRow(MsiAzureResource.VM, SomeRandomGuid, UserAssignedIdentityId.ObjectId, DisplayName = "ObjectId_VM")]
-        //[DataRow(MsiAzureResource.VM, Non_Existent_UamiResourceId, UserAssignedIdentityId.ResourceId, DisplayName = "ResourceID_VM")]
         public async Task ManagedIdentityRequestFailureCheckAsync(MsiAzureResource azureResource, string userIdentity, UserAssignedIdentityId userAssignedIdentityId)
         {
             RunOnHelper.AssertFramework(TargetFrameworks.NetCore);

tests/devapps/Managed Identity apps/MSIHelperService/Controllers/EnvironmentVariablesController.cs

@@ -55,14 +55,11 @@ public EnvironmentVariablesController(
                 MSIHelper.AzureResource.WebApp => await MSIHelper.GetWebAppEnvironmentVariablesAsync(
                     _logger).ConfigureAwait(false),
 
-                MSIHelper.AzureResource.Function => await MSIHelper.GetFunctionAppEnvironmentVariablesAsync(httpClient,
-                    _logger).ConfigureAwait(false),
+                MSIHelper.AzureResource.Function => throw new NotImplementedException(),
 
-                MSIHelper.AzureResource.VM => await MSIHelper.GetVirtualMachineEnvironmentVariables(
-                    _logger).ConfigureAwait(false),
+                MSIHelper.AzureResource.VM => throw new NotImplementedException(),
 
-                MSIHelper.AzureResource.AzureArc => await MSIHelper.GetAzureArcEnvironmentVariables(
-                    _logger).ConfigureAwait(false),
+                MSIHelper.AzureResource.AzureArc => throw new NotImplementedException(),
 
                 MSIHelper.AzureResource.ServiceFabric => throw new NotImplementedException(),
 

tests/devapps/Managed Identity apps/MSIHelperService/Controllers/MSITokenController.cs

@@ -63,23 +63,11 @@ public MSITokenController(
                     httpClient,
                     _logger).ConfigureAwait(false),
 
-                MSIHelper.AzureResource.Function => await MSIHelper.GetFunctionAppMSIToken(
-                    identityHeader,
-                    uri,
-                    httpClient,
-                    _logger).ConfigureAwait(false),
+                MSIHelper.AzureResource.Function => throw new NotImplementedException(),
 
-                MSIHelper.AzureResource.VM => await MSIHelper.GetVirtualMachineMSIToken(
-                    identityHeader, 
-                    uri, 
-                    httpClient,
-                    _logger).ConfigureAwait(false),
+                MSIHelper.AzureResource.VM => throw new NotImplementedException(),
 
-                MSIHelper.AzureResource.AzureArc => await MSIHelper.GetAzureArcMSIToken(
-                    identityHeader,
-                    uri,
-                    httpClient,
-                    _logger).ConfigureAwait(false),
+                MSIHelper.AzureResource.AzureArc => throw new NotImplementedException(),
 
                 MSIHelper.AzureResource.ServiceFabric => throw new NotImplementedException(),