Remove unused constant

Author: bgavrilMS

tests/Microsoft.Identity.Test.LabInfrastructure/LabAuthenticationHelper.cs

@@ -16,33 +16,21 @@ namespace Microsoft.Identity.Test.LabInfrastructure
 {
     internal static class LabAuthenticationHelper
     {
-        public static async Task<AccessToken> GetAccessTokenForLabAPIAsync(string labAccessClientId)
+        public static async Task<AccessToken> GetAccessTokenForLabAPIAsync()
         {
             string[] scopes = [LabApiConstants.LabScope];
 
             return await GetLabAccessTokenAsync(
                 LabApiConstants.LabClientInstance + LabApiConstants.LabClientTenantId, 
-                scopes,  
-                labAccessClientId).ConfigureAwait(false);
+                scopes).ConfigureAwait(false);
         }
 
         public static async Task<AccessToken> GetLabAccessTokenAsync(string authority, string[] scopes)
-        {
-            return await GetLabAccessTokenAsync(
-                authority,
-                scopes,
-                String.Empty).ConfigureAwait(false);
-        }
-
-        public static async Task<AccessToken> GetLabAccessTokenAsync(string authority, string[] scopes, string clientId)
         {
             AuthenticationResult authResult;
             IConfidentialClientApplication confidentialApp;
             X509Certificate2 cert;
 
-            var clientIdForCertAuth = String.IsNullOrEmpty(clientId) ?
-                LabApiConstants.LabClientId : clientId;
-
             cert = CertificateHelper.FindCertificateByName(TestConstants.AutomationTestCertName);
             if (cert == null)
             {
@@ -51,7 +39,7 @@ public static async Task<AccessToken> GetLabAccessTokenAsync(string authority, s
             }
 
             confidentialApp = ConfidentialClientApplicationBuilder
-                .Create(clientIdForCertAuth)
+                .Create(LabApiConstants.LabClientId)
                 .WithAuthority(new Uri(authority), true)
                 .WithCacheOptions(CacheOptions.EnableSharedCacheOptions)
                 .WithCertificate(cert, true)

tests/Microsoft.Identity.Test.LabInfrastructure/LabServiceApi.cs

@@ -17,22 +17,19 @@ namespace Microsoft.Identity.Test.LabInfrastructure
     /// </summary>
     public class LabServiceApi 
     {
-        private string _labAccessAppId;
         private AccessToken? _labApiAccessToken;
         private AccessToken? _msiHelperApiAccessToken;
 
         public LabServiceApi()
         {
-            KeyVaultSecretsProvider _keyVaultSecretsProvider = new KeyVaultSecretsProvider();
-            _labAccessAppId = _keyVaultSecretsProvider.GetSecretByName("LabVaultAppID").Value;
         }
 
         public async Task<string> GetMSIHelperServiceTokenAsync()
         {
             if (_msiHelperApiAccessToken == null)
             {
                 _msiHelperApiAccessToken = await LabAuthenticationHelper
-                    .GetAccessTokenForLabAPIAsync(_labAccessAppId)
+                    .GetAccessTokenForLabAPIAsync()
                     .ConfigureAwait(false);
             }
 
@@ -172,7 +169,7 @@ private async Task<string> SendLabRequestAsync(string requestUrl, Dictionary<str
         internal async Task<string> GetLabResponseAsync(string address)
         {
             if (_labApiAccessToken == null)
-                _labApiAccessToken = await LabAuthenticationHelper.GetAccessTokenForLabAPIAsync(_labAccessAppId).ConfigureAwait(false);
+                _labApiAccessToken = await LabAuthenticationHelper.GetAccessTokenForLabAPIAsync().ConfigureAwait(false);
 
             using (HttpClient httpClient = new HttpClient())
             {