Skip to content

Imdsv2: Generate CSR and execute CSR request #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Aug 27, 2025
Merged

Imdsv2: Generate CSR and execute CSR request #5427

merged 32 commits into from
Aug 27, 2025

Conversation

Robbie-Microsoft
Copy link
Contributor

@Robbie-Microsoft Robbie-Microsoft commented Aug 6, 2025 •
edited
Loading

.NET native CSR generation via RSA and ASN.1 Encoding. Tested with net462, net472, net8.0, netstandard2.0

gladjohn
gladjohn reviewed Aug 6, 2025
View reviewed changes
gladjohn
gladjohn reviewed Aug 6, 2025
View reviewed changes
@Robbie-Microsoft Robbie-Microsoft marked this pull request as ready for review August 6, 2025 22:07
@Robbie-Microsoft Robbie-Microsoft requested a review from a team as a code owner August 6, 2025 22:07
gladjohn
gladjohn reviewed Aug 7, 2025
View reviewed changes
gladjohn
gladjohn reviewed Aug 9, 2025
View reviewed changes
gladjohn
gladjohn reviewed Aug 25, 2025
View reviewed changes
@AzureAD AzureAD deleted a comment from bgavrilMS Aug 25, 2025
@gladjohn
Copy link
Contributor

Looks good overall, @Robbie-Microsoft, just a few minor comments remaining. I also see that the PR is already approved, so feel free to address the open comments and proceed with merging. Adding the suggested .NET 8 CSR comparison test would also be valuable for extra confidence and long-term regression coverage.

@Robbie-Microsoft Robbie-Microsoft merged commit 8c03bb3 into rginsburg/msiv2_feature_branch Aug 27, 2025
3 checks passed
@Robbie-Microsoft Robbie-Microsoft deleted the rginsburg/msiv2_csr branch August 27, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gladjohn gladjohn gladjohn left review comments

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS

+1 more reviewer

@bartonjs bartonjs bartonjs left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Feature Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Robbie-Microsoft @gladjohn @bartonjs @bgavrilMS @neha-bhargava