Merge pull request #998 from Ugonnaak1/akaliugonna/deprecateROPC

Deprecate ROPC flow

Author: Avery-Dunn

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IPublicClientApplication.java

@@ -14,11 +14,15 @@
 public interface IPublicClientApplication extends IClientApplicationBase {
 
     /**
-     * Acquires tokens from the authority configured in the application via Username/Password authentication.
+     * Acquires tokens from the authority configured in the application via Username/Password authentication.<br>
+     * <p><b>Deprecated:</b> This API has been deprecated and will be removed in a future release. Use a more secure flow instead.<br>
+     * See <a href="https://aka.ms/msal-ropc-migration">https://aka.ms/msal-ropc-migration</a> for migration guidance.
      *
      * @param parameters instance of {@link UserNamePasswordParameters}
      * @return {@link CompletableFuture} containing an {@link IAuthenticationResult}
+     * @deprecated This API not a secure flow and will be removed in a future release.
      */
+    @Deprecated
     CompletableFuture<IAuthenticationResult> acquireToken(UserNamePasswordParameters parameters);
 
     /**

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/PublicClientApplication.java

@@ -24,6 +24,7 @@ public class PublicClientApplication extends AbstractClientApplicationBase imple
     private boolean brokerEnabled;
 
     @Override
+    @Deprecated
     public CompletableFuture<IAuthenticationResult> acquireToken(UserNamePasswordParameters parameters) {
 
         validateNotNull("parameters", parameters);

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/UserNamePasswordParameters.java

@@ -13,8 +13,13 @@
  * Object containing parameters for Username/Password flow. Can be used as parameter to
  * {@link PublicClientApplication#acquireToken(UserNamePasswordParameters)}
  * <p>
+ * <p><b>Deprecated:</b> This class supports the Resource Owner Password Credentials (ROPC) flow,
+ * which is insecure and will be removed in a future release.</p>
+ *
+ * <p>See <a href="https://aka.ms/msal-ropc-migration">https://aka.ms/msal-ropc-migration</a> for migration guidance.</p>
  * For more details, see https://aka.ms/msal4j-username-password
  */
+@Deprecated
 public class UserNamePasswordParameters implements IAcquireTokenParameters {
 
     private Set<String> scopes;