Merge pull request #864 from AzureAD/avdunn/mi-sourcetype-static

Make getManagedIdentitySource static

Author: Avery-Dunn

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ManagedIdentityApplication.java

@@ -5,7 +5,6 @@
 
 import lombok.AccessLevel;
 import lombok.Getter;
-import lombok.Setter;
 import org.slf4j.LoggerFactory;
 
 import java.util.concurrent.CompletableFuture;
@@ -24,7 +23,8 @@ public class ManagedIdentityApplication extends AbstractApplicationBase implemen
     @Getter
     static TokenCache sharedTokenCache = new TokenCache();
 
-    @Getter(value = AccessLevel.PUBLIC)
+    //Deprecated the field in favor of the static getManagedIdentitySource method
+    @Deprecated
     ManagedIdentitySourceType managedIdentitySource = ManagedIdentityClient.getManagedIdentitySource();
 
     @Getter(value = AccessLevel.PACKAGE)
@@ -105,4 +105,13 @@ protected Builder self() {
             return this;
         }
     }
+
+    /**
+     * Returns a {@link ManagedIdentitySourceType} value, which is based primarily on environment variables set on the system.
+     *
+     * @return ManagedIdentitySourceType enum for source type
+     */
+    public static ManagedIdentitySourceType getManagedIdentitySource() {
+       return ManagedIdentityClient.getManagedIdentitySource();
+    }
 }

msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java

@@ -161,7 +161,7 @@ void managedIdentity_GetManagedIdentitySource(ManagedIdentitySourceType source,
                 .build();
 
         ManagedIdentitySourceType miClientSourceType = ManagedIdentityClient.getManagedIdentitySource();
-        ManagedIdentitySourceType miAppSourceType = miApp.managedIdentitySource;
+        ManagedIdentitySourceType miAppSourceType = ManagedIdentityApplication.getManagedIdentitySource();
         assertEquals(expectedSource, miClientSourceType);
         assertEquals(expectedSource, miAppSourceType);
     }