From a7adf8ecafd205ce346f0e5de63938dade429c87 Mon Sep 17 00:00:00 2001 From: avdunn Date: Wed, 29 Oct 2025 14:04:52 -0700 Subject: [PATCH 1/2] Deprecate extraQueryParameters --- .../microsoft/aad/msal4j/AuthorizationCodeParameters.java | 6 ++++++ .../aad/msal4j/AuthorizationRequestUrlParameters.java | 6 ++++++ .../microsoft/aad/msal4j/ClientCredentialParameters.java | 6 ++++++ .../com/microsoft/aad/msal4j/DeviceCodeFlowParameters.java | 6 ++++++ .../com/microsoft/aad/msal4j/IAcquireTokenParameters.java | 2 ++ .../msal4j/IntegratedWindowsAuthenticationParameters.java | 6 ++++++ .../microsoft/aad/msal4j/InteractiveRequestParameters.java | 6 ++++++ .../java/com/microsoft/aad/msal4j/OnBehalfOfParameters.java | 6 ++++++ .../com/microsoft/aad/msal4j/RefreshTokenParameters.java | 6 ++++++ .../java/com/microsoft/aad/msal4j/SilentParameters.java | 6 ++++++ .../microsoft/aad/msal4j/UserNamePasswordParameters.java | 6 ++++++ 11 files changed, 62 insertions(+) diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationCodeParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationCodeParameters.java index 7446ec95..8b430080 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationCodeParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationCodeParameters.java @@ -92,6 +92,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -173,7 +177,9 @@ public AuthorizationCodeParametersBuilder extraHttpHeaders(Map e /** * Adds additional query parameters to the token request + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public AuthorizationCodeParametersBuilder extraQueryParameters(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java index 02f75f11..bc92b006 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java @@ -234,6 +234,10 @@ public boolean instanceAware() { return this.instanceAware; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -419,7 +423,9 @@ public Builder instanceAware(boolean val) { /** * Query parameters that you can add to the request, * in addition to the list of parameters already provided. + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public Builder extraQueryParameters(Map val) { this.extraQueryParameters = val; return self(); diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ClientCredentialParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ClientCredentialParameters.java index b7d66a6f..c6168dfe 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ClientCredentialParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ClientCredentialParameters.java @@ -71,6 +71,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -134,7 +138,9 @@ public ClientCredentialParametersBuilder extraHttpHeaders(Map ex /** * Adds additional query parameters to the token request + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public ClientCredentialParametersBuilder extraQueryParameters(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/DeviceCodeFlowParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/DeviceCodeFlowParameters.java index 40fd23b7..bfd3ab54 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/DeviceCodeFlowParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/DeviceCodeFlowParameters.java @@ -70,6 +70,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -135,7 +139,9 @@ public DeviceCodeFlowParametersBuilder extraHttpHeaders(Map extr /** * Adds additional query parameters to the token request + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public DeviceCodeFlowParametersBuilder extraQueryParameters(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java index 89f02fe4..f6b9f8cc 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java @@ -62,6 +62,8 @@ interface IAcquireTokenParameters { * This can be useful for scenarios requiring custom parameters that aren't explicitly supported in the library. * * @return A map of additional query parameters to include with the token request, or null if no extra parameters are needed. + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated Map extraQueryParameters(); } diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IntegratedWindowsAuthenticationParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IntegratedWindowsAuthenticationParameters.java index c6a5109c..1acb5e31 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IntegratedWindowsAuthenticationParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IntegratedWindowsAuthenticationParameters.java @@ -72,6 +72,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -129,7 +133,9 @@ public IntegratedWindowsAuthenticationParametersBuilder extraHttpHeaders(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java index 1a56e482..cb988606 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java @@ -113,6 +113,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -262,7 +266,9 @@ public InteractiveRequestParametersBuilder extraHttpHeaders(Map /** * Adds additional query parameters to the token request + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public InteractiveRequestParametersBuilder extraQueryParameters(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/OnBehalfOfParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/OnBehalfOfParameters.java index 7f151d1f..f954c32b 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/OnBehalfOfParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/OnBehalfOfParameters.java @@ -76,6 +76,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -136,7 +140,9 @@ public OnBehalfOfParametersBuilder extraHttpHeaders(Map extraHtt /** * Adds additional parameters to the token request + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public OnBehalfOfParametersBuilder extraQueryParameters(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/RefreshTokenParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/RefreshTokenParameters.java index 8c2746be..35a3e661 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/RefreshTokenParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/RefreshTokenParameters.java @@ -72,6 +72,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -133,7 +137,9 @@ public RefreshTokenParametersBuilder extraHttpHeaders(Map extraH /** * Adds additional parameters to the token request + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public RefreshTokenParametersBuilder extraQueryParameters(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/SilentParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/SilentParameters.java index 6d863303..a2c3ad57 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/SilentParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/SilentParameters.java @@ -119,6 +119,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -215,7 +219,9 @@ public SilentParametersBuilder extraHttpHeaders(Map extraHttpHea /** * Adds additional query parameters to the token request + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public SilentParametersBuilder extraQueryParameters(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/UserNamePasswordParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/UserNamePasswordParameters.java index d8a3a2d8..9f9b5836 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/UserNamePasswordParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/UserNamePasswordParameters.java @@ -88,6 +88,10 @@ public Map extraHttpHeaders() { return this.extraHttpHeaders; } + /** + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. + */ + @Deprecated public Map extraQueryParameters() { return this.extraQueryParameters; } @@ -180,7 +184,9 @@ public UserNamePasswordParametersBuilder extraHttpHeaders(Map ex /** * Adds additional query parameters to the token request + * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ + @Deprecated public UserNamePasswordParametersBuilder extraQueryParameters(Map extraQueryParameters) { this.extraQueryParameters = extraQueryParameters; return this; From 75bad75776a232d9a0ff73a26605c79fdcafa4f9 Mon Sep 17 00:00:00 2001 From: avdunn Date: Tue, 4 Nov 2025 09:39:22 -0800 Subject: [PATCH 2/2] Re-trigger Github checks --- .../java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java | 1 + 1 file changed, 1 insertion(+) diff --git a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java index f6b9f8cc..5c6acb9d 100644 --- a/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java +++ b/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java @@ -62,6 +62,7 @@ interface IAcquireTokenParameters { * This can be useful for scenarios requiring custom parameters that aren't explicitly supported in the library. * * @return A map of additional query parameters to include with the token request, or null if no extra parameters are needed. + * * @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API. */ @Deprecated