Skip to content

Commit 2e533d5

Browse files
tnorlingkonstantin-msft
authored andcommitted
resolve comments
1 parent 9fc5585 commit 2e533d5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/copilot-instructions.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,10 @@ npm run beachball:check
107107
- `Major`: Breaking changes (Never make breaking changes to libraries)
108108

109109
**Change Message:**
110-
Change message should always include a description of the change followed by the PR number (as a link to the PR). For example:
111-
Fix documentation [#7880](https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/7880)
110+
Change message should always include a description of the change followed by the PR number (as a link to the PR).
111+
112+
Template: Brief description of change [#XXXX](PR_URL)
113+
Example: Fix documentation [#7880](https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/7880)
112114

113115
### Common Build Issues and Solutions
114116

@@ -268,9 +270,7 @@ export const PerformanceEvents = {
268270
#### Telemetry Best Practices
269271

270272
- **Always include correlationId** for request tracing
271-
- **Use `startMeasurement/end`** for complex operations where you need to track duration and add custom fields
272-
- **Add relevant fields** like operation counts, cache hit/miss, error codes using `measurement.add()`
273-
- **Handle errors properly** by calling `measurement.end()` with error parameter
273+
- **Add relevant fields** like operation counts, cache hit/miss, error codes using `performanceClient.addFields()`
274274
- **Use existing PerformanceEvents** when possible rather than creating new ones
275275

276276
### Working with the Codebase

0 commit comments

Comments
 (0)