Commit ba6655b
authored
Add backward compatibility support (#7962)
This pull request adds support for client capabilities in the custom
authentication flows of `@azure/msal-browser`, enabling the client to
declare which authentication features it supports when interacting with
the Microsoft Entra backend. It also refactors how redirect-required
errors are handled and simplifies error classes related to sign-in,
sign-up, and password reset flows.
**Custom Authentication Capabilities Support:**
* Added a `capabilities` field to `CustomAuthOptions`, allowing clients
to specify supported features (e.g., MFA, registration) in the
configuration
(`lib/msal-browser/src/custom_auth/configuration/CustomAuthConfiguration.ts`).
[[1]](diffhunk://#diff-5e18147940e49db10c140f6f1547464c2ca5a6a5e49767b129568bca042d4e68R14)
[[2]](diffhunk://#diff-f98ffa0d9403f1827bd9bbad2ffe5b540194bc8da456e63d52c2958cb53309bbR48-R52)
* Propagated the `capabilities` array through the `CustomAuthApiClient`
and down to the `SignInApiClient`, `SignupApiClient`, and
`ResetPasswordApiClient` classes, which now include these capabilities
in their API requests (`CustomAuthApiClient.ts`, `SignInApiClient.ts`,
`SignupApiClient.ts`, `ResetPasswordApiClient.ts`).
[[1]](diffhunk://#diff-e4bffa17d39a62bd6d7c57db17850e1f22788b8646f226554c95fd690ee8de75L20-R39)
[[2]](diffhunk://#diff-e9a2087346a3cd1aba8abd540d01c2d10396a55b66935e8c03b59383251ab4f8L115-R116)
[[3]](diffhunk://#diff-e7a4d56565aaa98f4c89dc3954e27233d4f5c480f180a86478a3901da6f90ae5R12)
[[4]](diffhunk://#diff-e7a4d56565aaa98f4c89dc3954e27233d4f5c480f180a86478a3901da6f90ae5R31-R42)
[[5]](diffhunk://#diff-e7a4d56565aaa98f4c89dc3954e27233d4f5c480f180a86478a3901da6f90ae5R54-R57)
[[6]](diffhunk://#diff-0f28d0a272570d542dad8bd119415ae0363070a901540fc455e8b16f10e3c1a6R10)
[[7]](diffhunk://#diff-0f28d0a272570d542dad8bd119415ae0363070a901540fc455e8b16f10e3c1a6R27-R38)
[[8]](diffhunk://#diff-0f28d0a272570d542dad8bd119415ae0363070a901540fc455e8b16f10e3c1a6R52-R55)
[[9]](diffhunk://#diff-f074b0fbd643127fd46c37085055bad34adf3b7d1b9d4d4fc7fe0851bef5fe50R8)
[[10]](diffhunk://#diff-f074b0fbd643127fd46c37085055bad34adf3b7d1b9d4d4fc7fe0851bef5fe50R24-R35)
[[11]](diffhunk://#diff-f074b0fbd643127fd46c37085055bad34adf3b7d1b9d4d4fc7fe0851bef5fe50R49-R52)
* Updated API request type definitions to include the optional
`capabilities` field (`ApiRequestTypes.ts`).
[[1]](diffhunk://#diff-323a83bb10ebc94100586aadee937c29d77db9714dfed3e923894466976e5214R12)
[[2]](diffhunk://#diff-323a83bb10ebc94100586aadee937c29d77db9714dfed3e923894466976e5214R44)
[[3]](diffhunk://#diff-323a83bb10ebc94100586aadee937c29d77db9714dfed3e923894466976e5214R75)
**Error Handling Improvements:**
* Centralized the logic for determining if a redirect is required into
the base error class (`AuthFlowErrorBase.ts`), removing redundant
`isRedirectRequired` methods from specific error subclasses
(`SignInError.ts`, `SignUpError.ts`, `ResetPasswordError.ts`).
[[1]](diffhunk://#diff-d258b0a5af2cbf80110d814acf0b7df45e55bb0103bf53138e66020a93700a8bR152-R159)
[[2]](diffhunk://#diff-9bd88fec8e83fbb9e1d8e770f5ddc0cc395bda13033c70c787b85970f8d80841L34-L41)
[[3]](diffhunk://#diff-9bd88fec8e83fbb9e1d8e770f5ddc0cc395bda13033c70c787b85970f8d80841L78-R72)
[[4]](diffhunk://#diff-ddccd76ab42f6c83000ec1e1857a6322d82dbf78b3e9d47c6fa07d4c0e9488bbL49-L56)
[[5]](diffhunk://#diff-ddccd76ab42f6c83000ec1e1857a6322d82dbf78b3e9d47c6fa07d4c0e9488bbL79-R71)
[[6]](diffhunk://#diff-6992ffb0801330c7612d8d2fd7b160539d6e05284428a22dbf784b72c651702dL56-L63)
[[7]](diffhunk://#diff-6992ffb0801330c7612d8d2fd7b160539d6e05284428a22dbf784b72c651702dL76-L83)
[[8]](diffhunk://#diff-6992ffb0801330c7612d8d2fd7b160539d6e05284428a22dbf784b72c651702dL94-L101)
[[9]](diffhunk://#diff-6992ffb0801330c7612d8d2fd7b160539d6e05284428a22dbf784b72c651702dL120-R98)
* Simplified resend code error classes for sign-in, sign-up, and reset
password flows by removing unnecessary methods (`SignInResendCodeError`,
`SignUpResendCodeError`, `ResetPasswordResendCodeError`).
[[1]](diffhunk://#diff-9bd88fec8e83fbb9e1d8e770f5ddc0cc395bda13033c70c787b85970f8d80841L78-R72)
[[2]](diffhunk://#diff-ddccd76ab42f6c83000ec1e1857a6322d82dbf78b3e9d47c6fa07d4c0e9488bbL79-R71)
[[3]](diffhunk://#diff-6992ffb0801330c7612d8d2fd7b160539d6e05284428a22dbf784b72c651702dL120-R98)
**Redirect Error Enhancements:**
* Enhanced the `RedirectError` class to accept and display a more
specific redirect reason from the server, improving error messaging
(`CustomAuthApiError.ts`, `BaseApiClient.ts`).
[[1]](diffhunk://#diff-2dd77566c3e5ea80a8842413c962e06065c43583c961afb159cda2b07e87c5ebL13-R17)
[[2]](diffhunk://#diff-3a0d4ccac21db6d650f33cd543d93dd57d0505da0cc82a8cd38cfedbd5b3b55eL131-R134)
**Other:**
* Added a patch change file for backward compatibility support for
`@azure/msal-browser`.1 parent d8718bc commit ba6655b
File tree
17 files changed
+466
-91
lines changed- change
- lib/msal-browser
- src/custom_auth
- configuration
- controller
- core
- auth_flow
- error
- network_client/custom_auth_api
- reset_password/auth_flow/error_type
- sign_in/auth_flow/error_type
- sign_up/auth_flow/error_type
- test/custom_auth
- core
- error
- interaction_client
- network_client/custom_auth_api
17 files changed
+466
-91
lines changedLines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
| 116 | + | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
152 | 160 | | |
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
132 | 135 | | |
133 | 136 | | |
134 | 137 | | |
| |||
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | | - | |
| 26 | + | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
30 | | - | |
| 32 | + | |
| 33 | + | |
31 | 34 | | |
32 | 35 | | |
33 | 36 | | |
34 | 37 | | |
35 | | - | |
| 38 | + | |
| 39 | + | |
36 | 40 | | |
37 | 41 | | |
38 | 42 | | |
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
30 | 43 | | |
31 | 44 | | |
32 | 45 | | |
| |||
38 | 51 | | |
39 | 52 | | |
40 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
41 | 57 | | |
42 | 58 | | |
43 | 59 | | |
| |||
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
26 | 39 | | |
27 | 40 | | |
28 | 41 | | |
| |||
36 | 49 | | |
37 | 50 | | |
38 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
39 | 55 | | |
40 | 56 | | |
41 | 57 | | |
| |||
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
23 | 36 | | |
24 | 37 | | |
25 | 38 | | |
| |||
33 | 46 | | |
34 | 47 | | |
35 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
36 | 52 | | |
37 | 53 | | |
38 | 54 | | |
| |||
0 commit comments