Merge pull request #2379 from AzureAD/jarias/return-suberror-silent-calls

Save error received from ESTS, and use it to return to the client its description on silent broker calls [MSAL]

Author: juan-arias

MSAL/IdentityCore

@@ -30,6 +30,7 @@
 NSString *MSALErrorDomain = @"MSALErrorDomain";
 NSString *MSALOAuthErrorKey = @"MSALOAuthErrorKey";
 NSString *MSALOAuthSubErrorKey = @"MSALOAuthSubErrorKey";
+NSString *MSALOAuthSubErrorDescriptionKey = @"MSALOAuthSubErrorDescriptionKey";
 NSString *MSALErrorDescriptionKey = @"MSALErrorDescriptionKey";
 NSString *MSALSTSErrorCodesKey = @"MSALSTSErrorCodesKey";
 NSString *MSALInternalErrorCodeKey = @"MSALInternalErrorCodeKey";

MSAL/src/MSALError.m

@@ -142,6 +142,7 @@ + (void)initialize
                              MSIDSTSErrorCodesKey : MSALSTSErrorCodesKey,
                              MSIDOAuthErrorKey: MSALOAuthErrorKey,
                              MSIDOAuthSubErrorKey: MSALOAuthSubErrorKey,
+                             MSIDOAuthSubErrorDescriptionKey: MSALOAuthSubErrorDescriptionKey,
                              MSIDDeclinedScopesKey: MSALDeclinedScopesKey,
                              MSIDGrantedScopesKey: MSALGrantedScopesKey,
                              MSIDUserDisplayableIdkey: MSALDisplayableUserIdKey,

MSAL/src/MSALErrorConverter.m

@@ -56,6 +56,11 @@ extern NSString *MSALOAuthErrorKey;
  */
 extern NSString *MSALOAuthSubErrorKey;
 
+/**
+    The suberror description returned by the service.
+ */
+extern NSString *MSALOAuthSubErrorDescriptionKey;
+
 /**
     The extended error description. Note that this string can change and should
     not be relied upon for any error handling logic.