Skip to content

Commit 3af52b3

Browse files
committed
update private enum value of 1 to an official MSALPreferredAuthMethodQRPIN
1 parent 13eccf3 commit 3af52b3

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

MSAL/src/MSALDeviceInformation.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ - (MSALPreferredAuthMethod)msalPreferredAuthMethodFromMSIDPreferredAuthMethod:(M
128128
{
129129
switch (msidPreferredAuthConfig) {
130130
case MSIDPreferredAuthMethodQRPIN:
131-
return 1; // Private enum value for QR+PIN
131+
return MSALPreferredAuthMethodQRPIN;
132132

133133
default:
134134
return MSALPreferredAuthMethodNone;

MSAL/src/MSALPublicClientApplication.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,8 +1040,8 @@ - (void)acquireTokenWithParameters:(MSALInteractiveTokenParameters *)parameters
10401040
// Extra parameters to be added to the /authorize endpoint.
10411041
msidParams.extraAuthorizeURLQueryParameters = self.internalConfig.extraQueryParameters.extraAuthorizeURLQueryParameters;
10421042

1043-
// Private enum value for QR+PIN
1044-
if (parameters.preferredAuthMethod == 1)
1043+
// Setup QR+PIN accelerated experience if configured
1044+
if (parameters.preferredAuthMethod == MSALPreferredAuthMethodQRPIN)
10451045
{
10461046
NSMutableDictionary *extraAuthorizeURLQueryParameters = [msidParams.extraAuthorizeURLQueryParameters mutableCopy];
10471047
[extraAuthorizeURLQueryParameters setObject:MSID_PREFERRED_AUTH_METHOD_QR_PIN forKey:MSID_PREFERRED_AUTH_METHOD_KEY];

MSAL/src/public/MSALDefinitions.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,11 @@ typedef NS_ENUM(NSUInteger, MSALPreferredAuthMethod)
191191
/*
192192
No preferred auth method passed with the request to the authetication server.
193193
*/
194-
MSALPreferredAuthMethodNone
194+
MSALPreferredAuthMethodNone,
195+
/*
196+
QR+PIN authentication preferred.
197+
*/
198+
MSALPreferredAuthMethodQRPIN
195199
};
196200

197201
#if TARGET_OS_OSX

0 commit comments

Comments
 (0)