Skip to content

Commit 4f65bff

Browse files
committed
Revert "Skipping failing E2E tests for macOS due to Keychain access required by the Kevault component"
This reverts commit d239b4c.
1 parent d239b4c commit 4f65bff

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

MSAL/test/integration/native_auth/end_to_end/mfa/MSALNativeAuthSignInWithMFAEndToEndTests.swift

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ import MSAL
2929
final class MSALNativeAuthSignInWithMFAEndToEndTests: MSALNativeAuthEndToEndPasswordTestCase {
3030

3131
func test_signInUsingPasswordWithMFASubmitWrongChallengeResendChallengeThen_completeSuccessfully() async throws {
32-
#if os(macOS)
33-
throw XCTSkip("Keychain access is not active on the macOS app and is used by Keyvault")
34-
#endif
3532
guard let username = retrieveUsernameForSignInUsernamePasswordAndMFA(),
3633
let password = await retrievePasswordForSignInUsername(),
3734
let awaitingMFAState = await signInUsernameAndPassword(username: username, password: password)
@@ -88,9 +85,6 @@ final class MSALNativeAuthSignInWithMFAEndToEndTests: MSALNativeAuthEndToEndPass
8885
}
8986

9087
func test_signInUsingPasswordWithMFAGetAuthMethods_thenCompleteSuccessfully() async throws {
91-
#if os(macOS)
92-
throw XCTSkip("Keychain access is not active on the macOS app and is used by Keyvault")
93-
#endif
9488
guard let username = retrieveUsernameForSignInUsernamePasswordAndMFA(),
9589
let password = await retrievePasswordForSignInUsername(),
9690
let awaitingMFAState = await signInUsernameAndPassword(username: username, password: password)
@@ -146,9 +140,6 @@ final class MSALNativeAuthSignInWithMFAEndToEndTests: MSALNativeAuthEndToEndPass
146140
}
147141

148142
func test_signInUsingPasswordWithMFANoDefaultAuthMethod_completeSuccessfully() async throws {
149-
#if os(macOS)
150-
throw XCTSkip("Keychain access is not active on the macOS app and is used by Keyvault")
151-
#endif
152143
guard let username = retrieveUsernameForSignInUsernamePasswordAndMFANoDefaultAuthMethod(),
153144
let password = await retrievePasswordForSignInUsername(),
154145
let awaitingMFAState = await signInUsernameAndPassword(username: username, password: password)

MSAL/test/integration/native_auth/end_to_end/sign_in/MSALNativeAuthSignInUserNameAndPasswordEndToEndTests.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,6 @@ final class MSALNativeAuthSignInUsernameAndPasswordEndToEndTests: MSALNativeAuth
6666

6767
// Hero Scenario 1.2.1. Sign in - Use email and password to get token
6868
func test_signInUsingPasswordWithKnownUsernameResultsInSuccess() async throws {
69-
#if os(macOS)
70-
throw XCTSkip("Keychain access is not active on the macOS app and is used by Keyvault")
71-
#endif
7269
guard let sut = initialisePublicClientApplication(), let username = retrieveUsernameForSignInUsernameAndPassword(), let password = await retrievePasswordForSignInUsername() else {
7370
XCTFail("Missing information")
7471
return

0 commit comments

Comments
 (0)