Skip to content

Commit 7ef79b5

Browse files
authored
Merge pull request #2550 from AzureAD/jarias/use-single-frt
Use single FRT
2 parents 9fef65b + c393647 commit 7ef79b5

File tree

4 files changed

+37
-1
lines changed

4 files changed

+37
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## [TBD]
2+
* Use a single family refresh token (#2550)
3+
14
## [1.9.0]
25
* Add feature flags provider to be controlled from broker (#2540)
36
* Added GitHub issue templates for better issue tracking and reporting (#2554)

MSAL/test/app/ios/MSALTestAppCacheViewController.m

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#import "MSALAccount+Internal.h"
3434
#import "MSIDBaseToken.h"
3535
#import "MSIDRefreshToken.h"
36+
#import "MSIDFamilyRefreshToken.h"
3637
#import "MSIDAccessToken.h"
3738
#import "MSIDIdToken.h"
3839
#import "MSIDLegacyTokenCacheAccessor.h"
@@ -163,6 +164,7 @@ - (void)deleteToken:(MSIDBaseToken *)token
163164
{
164165
switch (token.credentialType)
165166
{
167+
case MSIDFamilyRefreshTokenType:
166168
case MSIDRefreshTokenType:
167169
{
168170
if ([token isKindOfClass:[MSIDLegacyRefreshToken class]])
@@ -469,6 +471,20 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N
469471
}
470472
break;
471473
}
474+
case MSIDFamilyRefreshTokenType:
475+
{
476+
MSIDFamilyRefreshToken *familyRefreshToken = (MSIDFamilyRefreshToken *) token;
477+
478+
cell.textLabel.text = [NSString stringWithFormat:@"FamilyRefreshToken : %@, FamilyId : %@", familyRefreshToken.clientId, familyRefreshToken.familyId ? familyRefreshToken.familyId : @"0"];
479+
cell.detailTextLabel.text = [NSString stringWithFormat:@"Client_Id: %@", familyRefreshToken.clientId];
480+
481+
if ([familyRefreshToken.refreshToken isEqualToString:BAD_REFRESH_TOKEN])
482+
{
483+
cell.textLabel.textColor = [UIColor orangeColor];
484+
cell.detailTextLabel.text = [NSString stringWithFormat:@"Client_Id : %@", familyRefreshToken.clientId];
485+
}
486+
break;
487+
}
472488
case MSIDAccessTokenType:
473489
{
474490
MSIDAccessToken *accessToken = (MSIDAccessToken *) token;
@@ -571,6 +587,7 @@ - (UISwipeActionsConfiguration *)tableView:(__unused UITableView *)tableView tra
571587

572588
switch (token.credentialType)
573589
{
590+
case MSIDFamilyRefreshTokenType:
574591
case MSIDRefreshTokenType:
575592
{
576593
if ([token isKindOfClass:[MSIDLegacyRefreshToken class]])

MSAL/test/app/mac/MSALCacheViewController.m

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
#import "MSIDAccountIdentifier.h"
3737
#import "MSIDBaseToken.h"
3838
#import "MSIDRefreshToken.h"
39+
#import "MSIDFamilyRefreshToken.h"
3940
#import "MSIDAccessToken.h"
4041
#import "MSIDIdToken.h"
4142
#import "MSIDKeychainTokenCache.h"
@@ -234,6 +235,7 @@ - (void)deleteToken:(MSIDBaseToken *)token
234235
{
235236
switch (token.credentialType)
236237
{
238+
case MSIDFamilyRefreshTokenType:
237239
case MSIDRefreshTokenType:
238240
{
239241
[self.defaultAccessor validateAndRemoveRefreshToken:(MSIDRefreshToken *)token
@@ -365,6 +367,20 @@ - (NSView *)outlineView:(NSOutlineView *)outlineView viewForTableColumn:(NSTable
365367
MSIDBaseToken *token = (MSIDBaseToken *)item;
366368
switch (token.credentialType)
367369
{
370+
case MSIDFamilyRefreshTokenType:
371+
{
372+
MSIDFamilyRefreshToken *familyRefreshToken = (MSIDFamilyRefreshToken *)token;
373+
textValue = [NSString stringWithFormat:@"Family Refresh Token: ClientId - %@, Realm - %@, FamilyId - %@", familyRefreshToken.clientId, familyRefreshToken.realm, familyRefreshToken.familyId];
374+
375+
if ([familyRefreshToken.refreshToken isEqualToString:s_badRefreshToken])
376+
{
377+
cellView.textField.textColor = [NSColor redColor];
378+
[cellView.textField setStringValue:textValue];
379+
return cellView;
380+
}
381+
382+
break;
383+
}
368384
case MSIDRefreshTokenType:
369385
{
370386
MSIDRefreshToken *refreshToken = (MSIDRefreshToken *) token;

0 commit comments

Comments
 (0)