Skip to content

Commit 8dfec63

Browse files
author
Swasti Gupta
committed
Update method description and error message for parentViewContoller
1 parent 44df08b commit 8dfec63

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

MSAL/src/MSIDInteractiveRequestParameters+MSALRequest.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ - (BOOL)fillWithWebViewParameters:(MSALWebviewParameters *)webParameters
5555

5656
if (parentViewController.view.window == nil)
5757
{
58-
NSError *msidError = MSIDCreateError(MSIDErrorDomain, MSIDErrorInvalidDeveloperParameter, @"parentViewController has no window! Provide a valid controller with view and window.", nil, nil, nil, nil, nil, YES);
58+
NSError *msidError = MSIDCreateError(MSIDErrorDomain, MSIDErrorInvalidDeveloperParameter, @"parentViewController has no window! Provide a valid controller with its view attached to a valid window.", nil, nil, nil, nil, nil, YES);
5959
if (error) *error = msidError;
6060
return NO;
6161
}

MSAL/src/public/MSALWebviewParameters.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ NS_ASSUME_NONNULL_BEGIN
4444
#pragma mark - Configuration options
4545

4646
/**
47-
The view controller to present from. This property must be valid. If nil is provided, or if the view controller is not attached to a window (i.e., parentViewController.view.window is nil), MSAL will return an error and will not proceed with authentication.
48-
It is required to provide a valid parentViewController with a window to proceed with authentication.
47+
The view controller to present from. If nil is provided, or if the view controller's view is not attached to a window (i.e., parentViewController.view.window is nil), MSAL will return an error and will not proceed with authentication.
48+
A valid parentViewController with its view attached to a valid window is required to proceed with authentication.
4949
*/
5050
@property (nonatomic, strong, nonnull) MSALViewController *parentViewController;
5151

@@ -82,9 +82,9 @@ NS_ASSUME_NONNULL_BEGIN
8282
#pragma mark - Constructing MSALWebviewParameters
8383

8484
/**
85-
Creates an instance of MSALWebviewParameters with a provided parentViewController.
86-
@param parentViewController The view controller to present authorization UI from. This property must be valid
87-
@note parentViewController is mandatory on iOS 13+ and macOS 10.15+. If nil is provided, or if the view controller is not attached to a window (i.e., parentViewController.view.window is nil), MSAL will return an error and authentication will not proceed. It is required to provide a valid parentViewController with a window to proceed with authentication.
85+
Creates an instance of MSALWebviewParameters with the provided parentViewController.
86+
@param parentViewController The view controller to present authorization UI from.
87+
@note parentViewController is mandatory on iOS 13+ and macOS 10.15+. If nil is provided, or if the view controller's view is not attached to a window (i.e., parentViewController.view.window is nil), MSAL will return an error and authentication will not proceed. A valid parentViewController with its view attached to a valid window is required to proceed with authentication.
8888
*/
8989
- (nonnull instancetype)initWithAuthPresentationViewController:(nonnull MSALViewController *)parentViewController;
9090

0 commit comments

Comments
 (0)