Merge branch 'MSAL-2x-breaking-changes' into spetrescu/merge-dev-breaking-changes

Author: spetrescu84

CHANGELOG.md

@@ -1,3 +1,10 @@
+## [TBD]
+* Removed deprecated APIs, including legacy initializers, account management methods, token acquisition methods, and the MSALTelemetry interface (#2577)
+* Enforced requirement for a valid ParentViewController (with a window) in interactive token requests (#2590)
+* Removed deprecated methods from native auth public interface (#2588)
+* Removed the deprecated MSALLogger interface and implementation class (#2591)
+* Enforced a valid broker-capable redirect URI format for AAD scenarios (#2592)
+
 ## [1.9.0]
 * Add feature flags provider to be controlled from broker (#2540)
 * Added GitHub issue templates for better issue tracking and reporting (#2554)

MSAL/IdentityCore

@@ -27,8 +27,6 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
-      <Testables>
-      </Testables>
       <MacroExpansion>
          <BuildableReference
             BuildableIdentifier = "primary"
@@ -38,8 +36,8 @@
             ReferencedContainer = "container:MSAL.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
+      <Testables>
+      </Testables>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -62,8 +60,6 @@
             ReferencedContainer = "container:MSAL.xcodeproj">
          </BuildableReference>
       </BuildableProductRunnable>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"

MSAL/MSAL.xcodeproj/project.pbxproj

@@ -58,6 +58,7 @@ + (void)initialize
                                    @(MSIDErrorServerNonHttpsRedirect) : @(MSALInternalErrorNonHttpsRedirect),
                                    @(MSIDErrorMismatchedAccount): @(MSALInternalErrorMismatchedUser),
                                    @(MSIDErrorRedirectSchemeNotRegistered): @(MSALInternalErrorRedirectSchemeNotRegistered),
+                                   @(MSIDErrorInvalidRedirectURI): @(MSALInternalErrorInvalidRedirectURI),
 
                                    // Cache
                                    @(MSIDErrorCacheMultipleUsers) : @(MSALInternalErrorAmbiguousAccount),

MSAL/MSAL.xcodeproj/xcshareddata/xcschemes/MSAL Test App (Mac).xcscheme

@@ -47,54 +47,4 @@ - (instancetype)initWithScopes:(NSArray<NSString *> *)scopes
     return self;
 }
 
-- (instancetype)initWithScopes:(NSArray<NSString *> *)scopes
-{
-    return [self initWithScopes:scopes
-                  webviewParameters:[MSALWebviewParameters new]];
-}
-
-#if TARGET_OS_IPHONE
-
-- (void)setParentViewController:(UIViewController *)parentViewController
-{
-    self.webviewParameters.parentViewController = parentViewController;
-}
-
-- (UIViewController *)parentViewController
-{
-    return self.webviewParameters.parentViewController;
-}
-
-- (void)setPresentationStyle:(UIModalPresentationStyle)presentationStyle
-{
-    self.webviewParameters.presentationStyle = presentationStyle;
-}
-
-- (UIModalPresentationStyle)presentationStyle
-{
-    return self.webviewParameters.presentationStyle;
-}
-
-#endif
-
-- (void)setWebviewType:(MSALWebviewType)webviewType
-{
-    self.webviewParameters.webviewType = webviewType;
-}
-
-- (MSALWebviewType)webviewType
-{
-    return self.webviewParameters.webviewType;
-}
-
-- (void)setCustomWebview:(WKWebView *)customWebview
-{
-    self.webviewParameters.customWebview = customWebview;
-}
-
-- (WKWebView *)customWebview
-{
-    return self.webviewParameters.customWebview;
-}
-
 @end