Skip to content

Commit b25ddbb

Browse files
authored
Remove MFA and JIT Private Preview tag (#2632)
* Remove JIT experimental from SDK * Removed logging
1 parent ee78453 commit b25ddbb

File tree

5 files changed

+1
-13
lines changed

5 files changed

+1
-13
lines changed

MSAL/src/native_auth/controllers/jit/MSALNativeAuthJITController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ final class MSALNativeAuthJITController: MSALNativeAuthBaseController, MSALNativ
283283
})
284284
case .jitAuthMethodsSelectionRequired(_, _):
285285
return .init(.error(error: .init(type: .generalError,
286-
message: "Unexpected result received when trying to signIn: strong authentication method registration required.",
286+
message: "Unexpected result received when trying to signIn: strong authentication method registration required.", // swiftlint:disable:this line_length
287287
correlationId: context.correlationId(),
288288
errorCodes: [],
289289
errorUri: nil),

MSAL/src/native_auth/public/state_machine/state/JITStates+Internal.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ extension RegisterStrongAuthBaseState {
2626
func requestChallengeInternal(authMethod: MSALAuthMethod,
2727
verificationContact: String?) async -> MSALNativeAuthJITControlling.JITRequestChallengeControllerResponse {
2828
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
29-
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
3029
MSALNativeAuthLogger.log(level: .info, context: context, format: "RegisterStrongAuth, Request Challenge")
3130
return await controller.requestJITChallenge(continuationToken: continuationToken,
3231
authMethod: authMethod,
@@ -39,7 +38,6 @@ extension RegisterStrongAuthVerificationRequiredState {
3938

4039
func submitChallengeInternal(challenge: String) async -> MSALNativeAuthJITControlling.JITSubmitChallengeControllerResponse {
4140
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
42-
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
4341
MSALNativeAuthLogger.log(level: .info, context: context, format: "RegisterStrongAuth, Submit Challenge")
4442
guard inputValidator.isInputValid(challenge) else {
4543
MSALNativeAuthLogger.log(level: .error, context: context, format: "RegisterStrongAuth, invalid challenge")

MSAL/src/native_auth/public/state_machine/state/JITStates.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ public class RegisterStrongAuthBaseState: MSALNativeAuthBaseState {
6363
public class RegisterStrongAuthState: RegisterStrongAuthBaseState {
6464

6565
/// Requests the server to send the challenge to the default authentication method.
66-
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
6766
/// - Parameters:
6867
/// - parameters: Parameters used to challenge an authentication method
6968
/// - delegate: Delegate that receives callbacks for the operation.
@@ -91,7 +90,6 @@ public class RegisterStrongAuthVerificationRequiredState: RegisterStrongAuthBase
9190
}
9291

9392
/// Submits the challenge to verify the authentication method selected.
94-
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
9593
/// - Parameters:
9694
/// - challenge: Verification challenge that the user supplies.
9795
/// - delegate: Delegate that receives callbacks for the operation.
@@ -109,7 +107,6 @@ public class RegisterStrongAuthVerificationRequiredState: RegisterStrongAuthBase
109107
}
110108

111109
/// Requests the server to send the challenge to the default authentication method.
112-
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
113110
/// - Parameters:
114111
/// - parameters: Parameters used to challenge an authentication method
115112
/// - delegate: Delegate that receives callbacks for the operation.

MSAL/src/native_auth/public/state_machine/state/MFAStates+Internal.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import Foundation
2727
extension MFABaseState {
2828
func requestChallengeInternal(authMethod: MSALAuthMethod?) async -> MSALNativeAuthMFAControlling.MFARequestChallengeControllerResponse {
2929
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
30-
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
3130
MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, request challenge")
3231
return await controller.requestChallenge(
3332
continuationToken: continuationToken,
@@ -42,7 +41,6 @@ extension MFABaseState {
4241
extension MFARequiredState {
4342
func getAuthMethodsInternal() async -> MSALNativeAuthMFAControlling.MFAGetAuthMethodsControllerResponse {
4443
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
45-
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
4644
MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, get authentication methods")
4745
return await controller.getAuthMethods(
4846
continuationToken: continuationToken,
@@ -54,7 +52,6 @@ extension MFARequiredState {
5452

5553
func submitChallengeInternal(challenge: String) async -> MSALNativeAuthMFAControlling.MFASubmitChallengeControllerResponse {
5654
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
57-
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
5855
MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, submit challenge")
5956
guard inputValidator.isInputValid(challenge) else {
6057
MSALNativeAuthLogger.log(level: .error, context: context, format: "MFA, invalid challenge")

MSAL/src/native_auth/public/state_machine/state/MFAStates.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ import Foundation
7373
public class AwaitingMFAState: MFABaseState {
7474

7575
/// Requests the server to send the challenge to the default authentication method.
76-
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
7776
/// - Parameter delegate: Delegate that receives callbacks for the operation.
7877
public func requestChallenge(delegate: MFARequestChallengeDelegate) {
7978
baseRequestChallenge(authMethod: nil, delegate: delegate)
@@ -103,7 +102,6 @@ public class MFARequiredState: MFABaseState {
103102
}
104103

105104
/// Requests the server to send the challenge to the specified auth method or the default one.
106-
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
107105
/// - Parameters:
108106
/// - authMethod: Optional. The authentication method you want to use for sending the challenge
109107
/// - delegate: Delegate that receives callbacks for the operation.
@@ -112,7 +110,6 @@ public class MFARequiredState: MFABaseState {
112110
}
113111

114112
/// Requests the available MFA authentication methods.
115-
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
116113
/// - Parameter delegate: Delegate that receives callbacks for the operation.
117114
public func getAuthMethods(delegate: MFAGetAuthMethodsDelegate) {
118115
Task {
@@ -132,7 +129,6 @@ public class MFARequiredState: MFABaseState {
132129
}
133130

134131
/// Submits the MFA challenge to the server for verification.
135-
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
136132
/// - Parameters:
137133
/// - challenge: Verification challenge that the user supplies.
138134
/// - delegate: Delegate that receives callbacks for the operation.

0 commit comments

Comments
 (0)