Skip to content

Commit cac61ff

Browse files
authored
Merge pull request #2405 from AzureAD/oldalton/automation_tweaks
Update IdentityCore submodule + update MSAL parentViewController docs
2 parents da3f8c4 + 78ea25b commit cac61ff

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

MSAL/src/public/MSALWebviewParameters.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ NS_ASSUME_NONNULL_BEGIN
4444
#pragma mark - Configuration options
4545

4646
/**
47-
The view controller to present from. If nil, the current topmost view controller will be used.
47+
The view controller to present from. If nil, MSAL will attempt to still proceed with the authentication, but the results will be unexpected.
48+
It is strongly recommended to provide a non-null parentViewController to avoid unexpected results.
4849
*/
4950
@property (nullable, weak, nonatomic) MSALViewController *parentViewController;
5051

@@ -90,7 +91,7 @@ NS_ASSUME_NONNULL_BEGIN
9091
/**
9192
Creates an instance of MSALWebviewParameters with a provided parentViewController.
9293
@param parentViewController The view controller to present authorization UI from.
93-
@note parentViewController is mandatory on iOS 13+. It is strongly recommended on macOS 10.15+ to allow correct presentation of ASWebAuthenticationSession. If parentViewController is not provided on macOS 10.15+, MSAL will use application's keyWindow for presentation
94+
@note parentViewController is mandatory on iOS 13+ and macOS 10.15+. Your app will experience unexpected results if parentViewController is not provided.
9495
*/
9596
- (nonnull instancetype)initWithAuthPresentationViewController:(MSALViewController *)parentViewController;
9697

0 commit comments

Comments
 (0)