diff --git a/CHANGELOG.md b/CHANGELOG.md index aeb8be9f0..d91bba140 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +## [TBC] +* Removed warnings about Private Preview for Email OTP MFA and Register Strong Auth in native authentication (#2670) + ## [2.2.0] * Make native auth MFA feature more backward compatible (#2645) diff --git a/MSAL/IdentityCore b/MSAL/IdentityCore index b2e54cff6..ab6975153 160000 --- a/MSAL/IdentityCore +++ b/MSAL/IdentityCore @@ -1 +1 @@ -Subproject commit b2e54cff670c70b0caab9aa1e982416accc4a815 +Subproject commit ab6975153b0ede0c05a404fce994eb2d80569909 diff --git a/MSAL/src/native_auth/public/state_machine/state/JITStates+Internal.swift b/MSAL/src/native_auth/public/state_machine/state/JITStates+Internal.swift index 0c5c804e9..67720beda 100644 --- a/MSAL/src/native_auth/public/state_machine/state/JITStates+Internal.swift +++ b/MSAL/src/native_auth/public/state_machine/state/JITStates+Internal.swift @@ -26,7 +26,6 @@ extension RegisterStrongAuthBaseState { func requestChallengeInternal(authMethod: MSALAuthMethod, verificationContact: String?) async -> MSALNativeAuthJITControlling.JITRequestChallengeControllerResponse { let context = MSALNativeAuthRequestContext(correlationId: correlationId) - MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog) MSALNativeAuthLogger.log(level: .info, context: context, format: "RegisterStrongAuth, Request Challenge") return await controller.requestJITChallenge(continuationToken: continuationToken, authMethod: authMethod, @@ -39,7 +38,6 @@ extension RegisterStrongAuthVerificationRequiredState { func submitChallengeInternal(challenge: String) async -> MSALNativeAuthJITControlling.JITSubmitChallengeControllerResponse { let context = MSALNativeAuthRequestContext(correlationId: correlationId) - MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog) MSALNativeAuthLogger.log(level: .info, context: context, format: "RegisterStrongAuth, Submit Challenge") guard inputValidator.isInputValid(challenge) else { MSALNativeAuthLogger.log(level: .error, context: context, format: "RegisterStrongAuth, invalid challenge") diff --git a/MSAL/src/native_auth/public/state_machine/state/JITStates.swift b/MSAL/src/native_auth/public/state_machine/state/JITStates.swift index 29e5cb221..367ca7829 100644 --- a/MSAL/src/native_auth/public/state_machine/state/JITStates.swift +++ b/MSAL/src/native_auth/public/state_machine/state/JITStates.swift @@ -63,7 +63,6 @@ public class RegisterStrongAuthBaseState: MSALNativeAuthBaseState { public class RegisterStrongAuthState: RegisterStrongAuthBaseState { /// Requests the server to send the challenge to the default authentication method. - /// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications. /// - Parameters: /// - parameters: Parameters used to challenge an authentication method /// - delegate: Delegate that receives callbacks for the operation. @@ -91,7 +90,6 @@ public class RegisterStrongAuthVerificationRequiredState: RegisterStrongAuthBase } /// Submits the challenge to verify the authentication method selected. - /// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications. /// - Parameters: /// - challenge: Verification challenge that the user supplies. /// - delegate: Delegate that receives callbacks for the operation. @@ -109,7 +107,6 @@ public class RegisterStrongAuthVerificationRequiredState: RegisterStrongAuthBase } /// Requests the server to send the challenge to the default authentication method. - /// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications. /// - Parameters: /// - parameters: Parameters used to challenge an authentication method /// - delegate: Delegate that receives callbacks for the operation. diff --git a/MSAL/src/native_auth/public/state_machine/state/MFAStates+Internal.swift b/MSAL/src/native_auth/public/state_machine/state/MFAStates+Internal.swift index 2693f4771..4544e769f 100644 --- a/MSAL/src/native_auth/public/state_machine/state/MFAStates+Internal.swift +++ b/MSAL/src/native_auth/public/state_machine/state/MFAStates+Internal.swift @@ -27,7 +27,6 @@ import Foundation extension MFABaseState { func requestChallengeInternal(authMethod: MSALAuthMethod?) async -> MSALNativeAuthMFAControlling.MFARequestChallengeControllerResponse { let context = MSALNativeAuthRequestContext(correlationId: correlationId) - MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog) MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, request challenge") return await controller.requestChallenge( continuationToken: continuationToken, @@ -42,7 +41,6 @@ extension MFABaseState { extension MFARequiredState { func getAuthMethodsInternal() async -> MSALNativeAuthMFAControlling.MFAGetAuthMethodsControllerResponse { let context = MSALNativeAuthRequestContext(correlationId: correlationId) - MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog) MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, get authentication methods") return await controller.getAuthMethods( continuationToken: continuationToken, @@ -54,7 +52,6 @@ extension MFARequiredState { func submitChallengeInternal(challenge: String) async -> MSALNativeAuthMFAControlling.MFASubmitChallengeControllerResponse { let context = MSALNativeAuthRequestContext(correlationId: correlationId) - MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog) MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, submit challenge") guard inputValidator.isInputValid(challenge) else { MSALNativeAuthLogger.log(level: .error, context: context, format: "MFA, invalid challenge") diff --git a/MSAL/src/native_auth/public/state_machine/state/MFAStates.swift b/MSAL/src/native_auth/public/state_machine/state/MFAStates.swift index 0425dd83b..5bf92f9aa 100644 --- a/MSAL/src/native_auth/public/state_machine/state/MFAStates.swift +++ b/MSAL/src/native_auth/public/state_machine/state/MFAStates.swift @@ -73,7 +73,6 @@ import Foundation public class AwaitingMFAState: MFABaseState { /// Requests the server to send the challenge to the default authentication method. - /// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications. /// - Parameter delegate: Delegate that receives callbacks for the operation. public func requestChallenge(delegate: MFARequestChallengeDelegate) { baseRequestChallenge(authMethod: nil, delegate: delegate) @@ -103,7 +102,6 @@ public class MFARequiredState: MFABaseState { } /// Requests the server to send the challenge to the specified auth method or the default one. - /// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications. /// - Parameters: /// - authMethod: Optional. The authentication method you want to use for sending the challenge /// - delegate: Delegate that receives callbacks for the operation. @@ -112,7 +110,6 @@ public class MFARequiredState: MFABaseState { } /// Requests the available MFA authentication methods. - /// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications. /// - Parameter delegate: Delegate that receives callbacks for the operation. public func getAuthMethods(delegate: MFAGetAuthMethodsDelegate) { Task { @@ -132,7 +129,6 @@ public class MFARequiredState: MFABaseState { } /// Submits the MFA challenge to the server for verification. - /// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications. /// - Parameters: /// - challenge: Verification challenge that the user supplies. /// - delegate: Delegate that receives callbacks for the operation.