Merge pull request #140 from AzureAD/error_description-is-optional

error_description is optional

Author: rayluo

msal/application.py

@@ -576,8 +576,10 @@ def _acquire_token_silent_by_finding_specific_refresh_token(
                 **kwargs)
             if "error" not in response:
                 return response
-            logger.debug(
-                "Refresh failed. {error}: {error_description}".format(**response))
+            logger.debug("Refresh failed. {error}: {error_description}".format(
+                error=response.get("error"),
+                error_description=response.get("error_description"),
+                ))
             if break_condition(response):
                 break
 

tests/test_application.py

@@ -74,7 +74,7 @@ def test_unknown_orphan_app_will_attempt_frt_and_not_remove_it(self):
         logger.debug("%s.cache = %s", self.id(), self.cache.serialize())
         def tester(url, data=None, **kwargs):
             self.assertEqual(self.frt, data.get("refresh_token"), "Should attempt the FRT")
-            return Mock(status_code=200, json=Mock(return_value={
+            return Mock(status_code=400, json=Mock(return_value={
                 "error": "invalid_grant",
                 "error_description": "Was issued to another client"}))
         app._acquire_token_silent_by_finding_rt_belongs_to_me_or_my_family(