Skip to content

Commit 518711b

Browse files
committed
Clean up unused methods
1 parent 9971053 commit 518711b

File tree

1 file changed

+2
-25
lines changed

1 file changed

+2
-25
lines changed

msal/application.py

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -282,14 +282,6 @@ def acquire_token_by_device_flow(
282282

283283
class PublicClientApplication(ClientApplication): # browser app or mobile app
284284

285-
## TBD: what if redirect_uri is not needed in the constructor at all?
286-
## Device Code flow does not need redirect_uri anyway.
287-
288-
# OUT_OF_BAND = "urn:ietf:wg:oauth:2.0:oob"
289-
# def __init__(self, client_id, redirect_uri=None, **kwargs):
290-
# super(PublicClientApplication, self).__init__(client_id, **kwargs)
291-
# self.redirect_uri = redirect_uri or self.OUT_OF_BAND
292-
293285
def acquire_token_by_username_password(
294286
self, username, password, scopes=None, **kwargs):
295287
"""Gets a token for a given resource via user credentails."""
@@ -328,20 +320,6 @@ def _acquire_token_by_username_password_federated(
328320
b64encode(wstrust_result["token"]),
329321
grant_type=grant_type, scope=scopes, **kwargs)
330322

331-
def acquire_token(
332-
self,
333-
scope,
334-
# additional_scope=None, # See also get_authorization_request_url()
335-
login_hint=None,
336-
ui_options=None,
337-
# user=None, # TBD: It exists in MSAL-dotnet but not in MSAL-Android
338-
policy='',
339-
authority=None, # See get_authorization_request_url()
340-
extra_query_params=None,
341-
):
342-
# It will handle the TWO round trips of Authorization Code Grant flow.
343-
raise NotImplemented()
344-
345323

346324
class ConfidentialClientApplication(ClientApplication): # server-side web app
347325

@@ -352,7 +330,6 @@ def acquire_token_for_client(self, scopes, **kwargs):
352330
scope=scopes, # This grant flow requires no scope decoration
353331
**kwargs)
354332

355-
def acquire_token_on_behalf_of(
356-
self, user_assertion, scope, authority=None, policy=''):
357-
pass
333+
def acquire_token_on_behalf_of(self, user_assertion, scopes, authority=None):
334+
raise NotImplementedError()
358335

0 commit comments

Comments
 (0)