Skip to content

Commit 79efb89

Browse files
committed
Backport test improvements
1 parent 1ebc175 commit 79efb89

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tests/http_client.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,27 @@ def __init__(self, verify=True, proxies=None, timeout=None):
1010
self.timeout = timeout
1111

1212
def post(self, url, params=None, data=None, headers=None, **kwargs):
13+
assert not kwargs, "Our stack shouldn't leak extra kwargs: %s" % kwargs
1314
return MinimalResponse(requests_resp=self.session.post(
1415
url, params=params, data=data, headers=headers,
1516
timeout=self.timeout))
1617

1718
def get(self, url, params=None, headers=None, **kwargs):
19+
assert not kwargs, "Our stack shouldn't leak extra kwargs: %s" % kwargs
1820
return MinimalResponse(requests_resp=self.session.get(
1921
url, params=params, headers=headers, timeout=self.timeout))
2022

23+
def close(self): # Not required, but we use it to avoid a warning in unit test
24+
self.session.close()
25+
2126

2227
class MinimalResponse(object): # Not for production use
2328
def __init__(self, requests_resp=None, status_code=None, text=None):
2429
self.status_code = status_code or requests_resp.status_code
25-
self.text = text or requests_resp.text
30+
self.text = text if text is not None else requests_resp.text
2631
self._raw_resp = requests_resp
2732

2833
def raise_for_status(self):
29-
if self._raw_resp:
34+
if self._raw_resp is not None: # Turns out `if requests.response` won't work
35+
# cause it would be True when 200<=status<400
3036
self._raw_resp.raise_for_status()

0 commit comments

Comments
 (0)