Enable ThrottledHttpClient.close()

Author: rayluo

msal/throttled_http_client.py

@@ -128,7 +128,13 @@ def __init__(self, http_client, http_cache):
                 3600*24 if 200 <= result.status_code < 300 else 0,
             )(http_client.get)
 
+        self._http_client = http_client
+
     # The following 2 methods have been defined dynamically by __init__()
     #def post(self, *args, **kwargs): pass
     #def get(self, *args, **kwargs): pass
 
+    def close(self):
+        """MSAL won't need this. But we allow throttled_http_client.close() anyway"""
+        return self._http_client.close()
+

tests/test_throttled_http_client.py

@@ -35,6 +35,13 @@ def post(self, url, params=None, data=None, headers=None, **kwargs):
     def get(self, url, params=None, headers=None, **kwargs):
         return self._build_dummy_response()
 
+    def close(self):
+        raise CloseMethodCalled("Not used by MSAL, but our customers may use it")
+
+
+class CloseMethodCalled(Exception):
+    pass
+
 
 class TestHttpDecoration(unittest.TestCase):
 
@@ -163,3 +170,10 @@ def test_device_flow_retry_should_not_be_cached(self):
         logger.debug(http_cache)
         self.assertNotEqual(resp1.text, resp2.text, "Should return a new response")
 
+    def test_throttled_http_client_should_provide_close(self):
+        http_cache = {}
+        http_client = DummyHttpClient(status_code=200)
+        http_client = ThrottledHttpClient(http_client, http_cache)
+        with self.assertRaises(CloseMethodCalled):
+            http_client.close()
+