suggestion edits

Author: Ugonnaak1

msal/__init__.py

@@ -26,12 +26,12 @@
 #------------------------------------------------------------------------------
 
 from .application import (
-    __version__,
     ClientApplication,
     ConfidentialClientApplication,
     PublicClientApplication,
     )
 from .oauth2cli.oidc import Prompt, IdTokenError
+from .sku import __version__
 from .token_cache import TokenCache, SerializableTokenCache
 from .auth_scheme import PopAuthScheme
 from .managed_identity import (

msal/application.py

@@ -19,10 +19,9 @@
 from .region import _detect_region
 from .throttled_http_client import ThrottledHttpClient
 from .cloudshell import _is_running_in_cloud_shell
+from .sku import SKU, __version__
 
 
-# The __init__.py will import this. Not the other way around.
-__version__ = "1.31.1"  # When releasing, also check and bump our dependencies's versions if needed
 
 logger = logging.getLogger(__name__)
 _AUTHORITY_TYPE_CLOUDSHELL = "CLOUDSHELL"
@@ -770,7 +769,7 @@ def _build_client(self, client_credential, authority, skip_regional_client=False
         client_assertion = None
         client_assertion_type = None
         default_headers = {
-            "x-client-sku": "MSAL.Python", "x-client-ver": __version__,
+            "x-client-sku": SKU, "x-client-ver": __version__,
             "x-client-os": sys.platform,
             "x-ms-lib-capability": "retry-after, h429",
         }

msal/broker.py

@@ -7,7 +7,7 @@
 import time
 import uuid
 
-from .application import __version__
+from .sku import __version__, SKU
 
 
 logger = logging.getLogger(__name__)
@@ -141,7 +141,7 @@ def _enable_msa_pt(params):
 
 def _build_msal_runtime_auth_params(client_id, authority):
     params = pymsalruntime.MSALRuntimeAuthParameters(client_id, authority)
-    params.set_additional_parameter("msal_client_sku", "MSAL.Python")
+    params.set_additional_parameter("msal_client_sku", SKU)
     params.set_additional_parameter("msal_client_ver", __version__)
     return params
 

msal/sku.py

@@ -0,0 +1,6 @@
+"""This module is from where we recieve the client sku name and version.
+"""
+
+# The __init__.py will import this. Not the other way around.
+__version__ = "1.31.1" # When releasing, also check and bump our dependencies's versions if needed
+SKU = "MSAL.Python"