Map suberror into classification

Author: rayluo

msal/application.py

@@ -509,6 +509,14 @@ def acquire_token_silent_with_error(
                 if "error" not in result:
                     return result
                 final_result = result
+        if final_result and final_result.get("suberror"):
+            final_result["classification"] = {  # Suppress these suberrors, per #57
+                "bad_token": "",
+                "token_expired": "",
+                "protection_policy_required": "",
+                "client_mismatch": "",
+                "device_authentication_failed": "",
+                }.get(final_result["suberror"], final_result["suberror"])
         return final_result
 
     def _acquire_token_silent_from_cache_and_possibly_refresh_it(

tests/test_application.py

@@ -75,19 +75,35 @@ def test_cache_empty_will_be_returned_as_None(self):
         self.assertEqual(
             None, self.app.acquire_token_silent_with_error(['cache_miss'], self.account))
 
+    def test_acquire_token_silent_will_suppress_error(self):
+        error_response = {"error": "invalid_grant", "suberror": "xyz"}
+        def tester(url, **kwargs):
+            return Mock(status_code=400, json=Mock(return_value=error_response))
+        self.assertEqual(None, self.app.acquire_token_silent(
+            self.scopes, self.account, post=tester))
+
     def test_acquire_token_silent_with_error_will_return_error(self):
         error_response = {"error": "invalid_grant", "error_description": "xyz"}
         def tester(url, **kwargs):
             return Mock(status_code=400, json=Mock(return_value=error_response))
         self.assertEqual(error_response, self.app.acquire_token_silent_with_error(
             self.scopes, self.account, post=tester))
 
-    def test_acquire_token_silent_will_suppress_error(self):
-        error_response = {"error": "invalid_grant", "error_description": "xyz"}
+    def test_atswe_will_map_some_suberror_to_classification_as_is(self):
+        error_response = {"error": "invalid_grant", "suberror": "basic_action"}
         def tester(url, **kwargs):
             return Mock(status_code=400, json=Mock(return_value=error_response))
-        self.assertEqual(None, self.app.acquire_token_silent(
-            self.scopes, self.account, post=tester))
+        result = self.app.acquire_token_silent_with_error(
+            self.scopes, self.account, post=tester)
+        self.assertEqual("basic_action", result.get("classification"))
+
+    def test_atswe_will_map_some_suberror_to_classification_to_empty_string(self):
+        error_response = {"error": "invalid_grant", "suberror": "client_mismatch"}
+        def tester(url, **kwargs):
+            return Mock(status_code=400, json=Mock(return_value=error_response))
+        result = self.app.acquire_token_silent_with_error(
+            self.scopes, self.account, post=tester)
+        self.assertEqual("", result.get("classification"))
 
 class TestClientApplicationAcquireTokenSilentFociBehaviors(unittest.TestCase):