Skip to content

Commit dc85e58

Browse files
authored
Merge branch 'dev' into dharshanb/brokerSupportLinux
2 parents e69bf25 + 30dce4e commit dc85e58

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

msal/application.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,11 @@ def _msal_extension_check():
210210
pass # The optional msal_extensions is not installed. Business as usual.
211211
except ValueError:
212212
logger.exception(f"msal_extensions version {v} not in major.minor.patch format")
213+
except:
214+
logger.exception(
215+
"Unable to import msal_extensions during an optional check. "
216+
"This exception can be safely ignored."
217+
)
213218

214219

215220
class ClientApplication(object):
@@ -331,7 +336,7 @@ def __init__(
331336
"client_assertion": "...a JWT with claims aud, exp, iss, jti, nbf, and sub..."
332337
}
333338
334-
.. admonition:: Supporting reading client cerficates from PFX files
339+
.. admonition:: Supporting reading client certificates from PFX files
335340
336341
*Added in version 1.29.0*:
337342
Feed in a dictionary containing the path to a PFX file::

msal/sku.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"""
33

44
# The __init__.py will import this. Not the other way around.
5-
__version__ = "1.31.1" # When releasing, also check and bump our dependencies's versions if needed
5+
__version__ = "1.32.0"
66
SKU = "MSAL.Python"

tests/test_e2e.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -936,10 +936,10 @@ def test_adfs2019_onprem_acquire_token_interactive(self):
936936
"Need LAB_OBO_CLIENT_SECRET from https://aka.ms/GetLabSecret?Secret=TodoListServiceV2-OBO")
937937
@unittest.skipUnless(
938938
os.getenv("LAB_OBO_CONFIDENTIAL_CLIENT_ID"),
939-
"Need LAB_OBO_CONFIDENTIAL_CLIENT_ID from https://docs.msidlab.com/flows/onbehalfofflow.html")
939+
"Need LAB_OBO_CONFIDENTIAL_CLIENT_ID from https://identitydivision.visualstudio.com/Engineering/_git/IDLABS?path=/src/DocFX/LabDocs/flows/onbehalfofflow.md&_a=preview")
940940
@unittest.skipUnless(
941941
os.getenv("LAB_OBO_PUBLIC_CLIENT_ID"),
942-
"Need LAB_OBO_PUBLIC_CLIENT_ID from https://docs.msidlab.com/flows/onbehalfofflow.html")
942+
"Need LAB_OBO_PUBLIC_CLIENT_ID from https://identitydivision.visualstudio.com/Engineering/_git/IDLABS?path=/src/DocFX/LabDocs/flows/onbehalfofflow.md&_a=preview")
943943
def test_acquire_token_obo(self):
944944
config = self.get_lab_user(usertype="cloud")
945945

@@ -1000,7 +1000,7 @@ def test_acquire_token_by_client_secret(self):
10001000
"Need LAB_OBO_CLIENT_SECRET from https://aka.ms/GetLabSecret?Secret=TodoListServiceV2-OBO")
10011001
@unittest.skipUnless(
10021002
os.getenv("LAB_OBO_CONFIDENTIAL_CLIENT_ID"),
1003-
"Need LAB_OBO_CONFIDENTIAL_CLIENT_ID from https://docs.msidlab.com/flows/onbehalfofflow.html")
1003+
"Need LAB_OBO_CONFIDENTIAL_CLIENT_ID from https://identitydivision.visualstudio.com/Engineering/_git/IDLABS?path=/src/DocFX/LabDocs/flows/onbehalfofflow.md&_a=preview")
10041004
def test_confidential_client_acquire_token_by_username_password(self):
10051005
# This approach won't work:
10061006
# config = self.get_lab_user(usertype="cloud", publicClient="no")
@@ -1217,10 +1217,10 @@ def test_acquire_token_for_client_should_use_an_env_var_with_long_region_name(se
12171217
"Need LAB_OBO_CLIENT_SECRET from https://aka.ms/GetLabSecret?Secret=TodoListServiceV2-OBO")
12181218
@unittest.skipUnless(
12191219
os.getenv("LAB_OBO_CONFIDENTIAL_CLIENT_ID"),
1220-
"Need LAB_OBO_CONFIDENTIAL_CLIENT_ID from https://docs.msidlab.com/flows/onbehalfofflow.html")
1220+
"Need LAB_OBO_CONFIDENTIAL_CLIENT_ID from https://identitydivision.visualstudio.com/Engineering/_git/IDLABS?path=/src/DocFX/LabDocs/flows/onbehalfofflow.md&_a=preview")
12211221
@unittest.skipUnless(
12221222
os.getenv("LAB_OBO_PUBLIC_CLIENT_ID"),
1223-
"Need LAB_OBO_PUBLIC_CLIENT_ID from https://docs.msidlab.com/flows/onbehalfofflow.html")
1223+
"Need LAB_OBO_PUBLIC_CLIENT_ID from https://identitydivision.visualstudio.com/Engineering/_git/IDLABS?path=/src/DocFX/LabDocs/flows/onbehalfofflow.md&_a=preview")
12241224
def test_cca_obo_should_bypass_regional_endpoint_therefore_still_work(self):
12251225
"""We test OBO because it is implemented in sub class ConfidentialClientApplication"""
12261226
config = self.get_lab_user(usertype="cloud")
@@ -1248,7 +1248,7 @@ def test_cca_obo_should_bypass_regional_endpoint_therefore_still_work(self):
12481248
"Need LAB_OBO_CLIENT_SECRET from https://aka.ms/GetLabSecret?Secret=TodoListServiceV2-OBO")
12491249
@unittest.skipUnless(
12501250
os.getenv("LAB_OBO_CONFIDENTIAL_CLIENT_ID"),
1251-
"Need LAB_OBO_CONFIDENTIAL_CLIENT_ID from https://docs.msidlab.com/flows/onbehalfofflow.html")
1251+
"Need LAB_OBO_CONFIDENTIAL_CLIENT_ID from https://identitydivision.visualstudio.com/Engineering/_git/IDLABS?path=/src/DocFX/LabDocs/flows/onbehalfofflow.md&_a=preview")
12521252
def test_cca_ropc_should_bypass_regional_endpoint_therefore_still_work(self):
12531253
"""We test ROPC because it is implemented in base class ClientApplication"""
12541254
config = self.get_lab_user(usertype="cloud")

0 commit comments

Comments
 (0)