[Bug] Managed Identity: In the Machine Learning source, the client id is sent incorrectly in the network request

[Robbie-Microsoft]

The Machine Learning source is based off of App Service 2017 (MSALs do not support this App Service 2017 version, only 2019). In the 2017 API, the client id should be passed to the network request as "clientid" instead of "client_id".

This bug was identified recently after Azure-SDK-for-JS removed their App Service 2017 implementation in favor of MSALJS's (msal-node) Machine Learning implementation. An Azure-SDK-for-JS customer is seeing network errors due to the incorrect way client id is being passed to the network request.

[rayluo]

Thanks for reporting, @Robbie-Microsoft .

MSAL Python has different code path for each managed identity, and its Machine Learning code path has already been using 2017 API, with proper clientid treatment. Please help review the implementation and, if it looks good to you, you can close this issue, Robbie.

[Robbie-Microsoft]

Thanks for reporting, @Robbie-Microsoft .

MSAL Python has different code path for each managed identity, and its Machine Learning code path has already been using 2017 API, with proper clientid treatment. Please help review the implementation and, if it looks good to you, you can close this issue, Robbie.

Thanks @rayluo. Maybe you could clarify the comment there. Is the 2017 API using "clientid" a "known bug"? Or is it just the way the 2017 API works? No need to respond here, just food for thought.

[rayluo]

Is the 2017 API using "clientid" a "known bug"? Or is it just the way the 2017 API works?

The use of "clientid" was presumably unintentional (thus a bug) in that 2017 API, because that kind of naming does not follow convention elsewhere. However, the moment that 2017 API was deployed, it became "just the way the 2017 API works". SDKs have no choice but to support that. The workaround in MSAL Python was also written in a way that only applied to 2017 API. You may also use it as a sample for your implementation. Feel free to ping me if you have any follow-up questions. @Robbie-Microsoft