Remove cyclic references from securityinsights schema

Author: anthony-c-martin

generator/autogenlist.ts

@@ -5,6 +5,7 @@ import { postProcessor as machineLearningPostProcessor } from './processors/Micr
 import { postProcessor as machineLearningServicesPostProcessor } from './processors/Microsoft.MachineLearningServices';
 import { postProcessor as storageProcessor } from './processors/Microsoft.Storage';
 import { postProcessor as policyProcessor } from './processors/Microsoft.Authorization';
+import { postProcessor as securityInsightsPostProcessor } from './processors/Microsoft.SecurityInsights';
 import { lowerCaseEquals } from './utils';
 
 // Run "npm run list-basepaths" to discover all the valid readme files to add to this list
@@ -598,6 +599,7 @@ const autoGenList: AutoGenConfig[] = [
     {
         basePath: 'securityinsights/resource-manager',
         namespace: 'Microsoft.SecurityInsights',
+        postProcessor: securityInsightsPostProcessor,
     },
     {
         basePath: 'storageimportexport/resource-manager',

generator/processors/Microsoft.MachineLearning.ts

@@ -1,9 +1,6 @@
 import { SchemaPostProcessor } from '../models';
+import { replaceCyclicRef } from './helpers';
 
 export const postProcessor: SchemaPostProcessor = (namespace: string, apiVersion: string, schema: any) => {
-  const cyclicRef = schema.definitions?.ModeValueInfo?.properties?.parameters?.oneOf[0]?.items;
-  if (cyclicRef && cyclicRef['$ref']) {
-    delete cyclicRef['$ref'];
-    cyclicRef['type'] = 'object';
-  }
+  replaceCyclicRef(schema.definitions?.ModeValueInfo?.properties?.parameters?.oneOf[0]?.items);
 }

generator/processors/Microsoft.MachineLearningServices.ts

@@ -1,9 +1,6 @@
 import { SchemaPostProcessor } from '../models';
+import { replaceCyclicRef } from './helpers';
 
 export const postProcessor: SchemaPostProcessor = (namespace: string, apiVersion: string, schema: any) => {
-  const cyclicRef = schema.definitions?.LabelClass?.properties?.subclasses?.oneOf[0]?.additionalProperties;
-  if (cyclicRef && cyclicRef['$ref']) {
-    delete cyclicRef['$ref'];
-    cyclicRef['type'] = 'object';
-  }
+  replaceCyclicRef(schema.definitions?.LabelClass?.properties?.subclasses?.oneOf[0]?.additionalProperties);
 }

generator/processors/Microsoft.SecurityInsights.ts

@@ -0,0 +1,6 @@
+import { SchemaPostProcessor } from '../models';
+import { replaceCyclicRef } from './helpers';
+
+export const postProcessor: SchemaPostProcessor = (namespace: string, apiVersion: string, schema: any) => {
+  replaceCyclicRef(schema.definitions?.MetadataDependencies?.properties?.criteria?.oneOf[0]?.items);
+}

generator/processors/helpers.ts

@@ -0,0 +1,6 @@
+export const replaceCyclicRef = (cyclicRef: any) => {
+  if (cyclicRef && cyclicRef['$ref']) {
+    delete cyclicRef['$ref'];
+    cyclicRef['type'] = 'object';
+  }
+}

schemas/2014-04-01-preview/deploymentTemplate.json

@@ -5964,9 +5964,6 @@
                   {
                     "$ref": "https://schema.management.azure.com/schemas/2015-04-01/Microsoft.DomainRegistration.json#/resourceDefinitions/domains_domainOwnershipIdentifiers"
                   },
-                  {
-                    "$ref": "https://schema.management.azure.com/schemas/2015-08-01/Microsoft.DomainRegistration.json#/resourceDefinitions/domains"
-                  },
                   {
                     "$ref": "https://schema.management.azure.com/schemas/2018-02-01/Microsoft.DomainRegistration.json#/resourceDefinitions/domains"
                   },

schemas/2015-01-01/deploymentTemplate.json

@@ -6374,9 +6374,6 @@
                   {
                     "$ref": "https://schema.management.azure.com/schemas/2015-04-01/Microsoft.DomainRegistration.json#/resourceDefinitions/domains_domainOwnershipIdentifiers"
                   },
-                  {
-                    "$ref": "https://schema.management.azure.com/schemas/2015-08-01/Microsoft.DomainRegistration.json#/resourceDefinitions/domains"
-                  },
                   {
                     "$ref": "https://schema.management.azure.com/schemas/2018-02-01/Microsoft.DomainRegistration.json#/resourceDefinitions/domains"
                   },

schemas/2021-03-01-preview/Microsoft.SecurityInsights.json

@@ -2385,7 +2385,7 @@
             {
               "type": "array",
               "items": {
-                "$ref": "#/definitions/MetadataDependencies"
+                "type": "object"
               }
             },
             {