Applied arch board feedback for Key Vault Keys (Azure#26910)

* Applied all arch board feedback but that about not using String for ISO8601 durations.

* Fixed Javadoc issue.

* Fixed Javadoc, Checkstyle and Spotbugs issues.

* Applied PR feedback.

* Removed `RandomBytes` and changed the return type of all `getRandomBytes()` operations to `byte[]`.

* Added links to a Wikipedia article on ISO 8601 durations where applicable for APIs and samples related to key rotation.

* Fixed issue with how requests were structured when a KeyRotationPolicy was sent.

* Updated test recordings.

Author: vcolin7

eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml

@@ -577,6 +577,7 @@
       <Class name="com.azure.security.keyvault.keys.cryptography.SecretKey"/>
       <Class name="com.azure.security.keyvault.keys.models.KeyVaultKey"/>
       <Class name="com.azure.security.keyvault.keys.models.KeyProperties"/>
+      <Class name="com.azure.security.keyvault.keys.models.KeyRotationPolicy"/>
       <Class name="com.azure.security.keyvault.certificates.models.DeletedCertificate"/>
       <Class name="com.azure.security.keyvault.certificates.models.Certificate"/>
       <Class name="com.azure.security.keyvault.certificates.models.CertificateProperties"/>

sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/KeyAsyncClient.java

@@ -16,7 +16,7 @@ class KeyReleaseParameters {
      * The attestation assertion for the target of the key release.
      */
     @JsonProperty(value = "target", required = true)
-    private String target;
+    private String targetAttestationToken;
 
     /*
      * A client provided nonce for freshness.
@@ -35,19 +35,19 @@ class KeyReleaseParameters {
      *
      * @return The target value.
      */
-    public String getTarget() {
-        return this.target;
+    public String getTargetAttestationToken() {
+        return this.targetAttestationToken;
     }
 
     /**
      * Set the attestation assertion for the target of the key release.
      *
-     * @param target The attestation assertion for the target of the key release.
+     * @param targetAttestationToken The attestation assertion for the target of the key release.
      *
      * @return The updated {@link KeyReleaseParameters} object.
      */
-    public KeyReleaseParameters setTarget(String target) {
-        this.target = target;
+    public KeyReleaseParameters setTargetAttestationToken(String targetAttestationToken) {
+        this.targetAttestationToken = targetAttestationToken;
 
         return this;
     }

sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/KeyClient.java

@@ -231,7 +231,7 @@ public KeyReleasePolicy getReleasePolicy() {
      * Set the policy rules under which the key can be exported.
      *
      * @param releasePolicy The policy rules to set.
-     * 
+     *
      * @return The updated {@link KeyRequestParameters} object.
      */
     public KeyRequestParameters setReleasePolicy(KeyReleasePolicy releasePolicy) {

sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/KeyExportRequestParameters.java

@@ -26,13 +26,13 @@
 import com.azure.core.util.Context;
 import com.azure.security.keyvault.keys.implementation.models.DeletedKeyPage;
 import com.azure.security.keyvault.keys.implementation.models.KeyPropertiesPage;
-import com.azure.security.keyvault.keys.implementation.models.KeyRotationPolicy;
 import com.azure.security.keyvault.keys.implementation.models.GetRandomBytesRequest;
 import com.azure.security.keyvault.keys.implementation.models.RandomBytes;
 import com.azure.security.keyvault.keys.models.DeletedKey;
 import com.azure.security.keyvault.keys.models.ReleaseKeyResult;
 import com.azure.security.keyvault.keys.models.KeyVaultKey;
 import com.azure.security.keyvault.keys.models.KeyProperties;
+import com.azure.security.keyvault.keys.models.KeyRotationPolicy;
 import reactor.core.publisher.Mono;
 
 /**

sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/KeyReleaseParameters.java

@@ -0,0 +1,26 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.azure.security.keyvault.keys.implementation;
+
+import com.azure.core.util.BinaryData;
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.JsonDeserializer;
+
+import java.io.IOException;
+
+public class BinaryDataJsonDeserializer  extends JsonDeserializer<BinaryData> {
+    @Override
+    public BinaryData deserialize(JsonParser jsonParser, DeserializationContext deserializationContext)
+        throws IOException {
+
+        String text = jsonParser.getText();
+
+        if (text != null) {
+            return BinaryData.fromString(text);
+        }
+
+        return null;
+    }
+}

sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/KeyRequestParameters.java

@@ -0,0 +1,36 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.azure.security.keyvault.keys.implementation;
+
+import com.azure.core.util.BinaryData;
+import com.fasterxml.jackson.core.JsonGenerator;
+import com.fasterxml.jackson.databind.JsonSerializer;
+import com.fasterxml.jackson.databind.SerializerProvider;
+
+import java.io.IOException;
+import java.util.Base64;
+
+public class BinaryDataJsonSerializer extends JsonSerializer<BinaryData> {
+    @Override
+    public void serialize(BinaryData value, JsonGenerator jsonGenerator, SerializerProvider provider)
+        throws IOException {
+        String text;
+
+        if (value == null) {
+            text = null;
+        } else {
+            byte[] bytes = value.toBytes();
+
+            if (bytes == null) {
+                text = null;
+            } else if (bytes.length == 0) {
+                text = "";
+            } else {
+                text = Base64.getUrlEncoder().withoutPadding().encodeToString(bytes);
+            }
+        }
+
+        jsonGenerator.writeString(text);
+    }
+}