Skip to content

Commit 7ea503b

Browse files
author
Rujun Chen
authored
1 parent 7610e84 commit 7ea503b

File tree

2 files changed

+12
-1
lines changed
  • sdk/keyvault/azure-security-keyvault-jca/src
    • main/java/com/azure/security/keyvault/jca/implementation/utils
    • test/java/com/azure/security/keyvault/jca/implementation/utils

2 files changed

+12
-1
lines changed

sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/HttpUtil.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.apache.http.client.methods.HttpPost;
1111
import org.apache.http.config.RegistryBuilder;
1212
import org.apache.http.conn.socket.ConnectionSocketFactory;
13+
import org.apache.http.conn.socket.PlainConnectionSocketFactory;
1314
import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
1415
import org.apache.http.entity.ContentType;
1516
import org.apache.http.entity.StringEntity;
@@ -129,6 +130,7 @@ private static CloseableHttpClient buildClient() {
129130

130131
PoolingHttpClientConnectionManager manager = new PoolingHttpClientConnectionManager(
131132
RegistryBuilder.<ConnectionSocketFactory>create()
133+
.register("http", PlainConnectionSocketFactory.getSocketFactory())
132134
.register("https", sslConnectionSocketFactory)
133135
.build());
134136
return HttpClients.custom().setConnectionManager(manager).build();

sdk/keyvault/azure-security-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/implementation/utils/HttpUtilTest.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,19 @@ public void getUserAgentPrefixTest() {
2020

2121
@Test
2222
@Disabled("Disable this because it will cause pipeline failure: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1196171&view=logs&j=4a83f3be-c53d-53dd-7954-86872056fb11&t=54174aae-5a55-579d-08e2-94fb446f7b77&l=29")
23-
public void testCustomizedHttpsClient() {
23+
public void testHttpUtilGet() {
2424
String url = "https://mvnrepository.com/";
2525
String result = HttpUtil.get(url, null);
2626
assertNotNull(result);
2727
assertFalse(result.isEmpty());
2828
}
29+
30+
@Test
31+
@Disabled("This is only used to test in localhost manually")
32+
public void testHttpUtilGet1() {
33+
String url = "http://localhost:8000/";
34+
String result = HttpUtil.get(url, null);
35+
assertNotNull(result);
36+
assertFalse(result.isEmpty());
37+
}
2938
}

0 commit comments

Comments
 (0)