add npe for query (Azure#26701)

* add npe for query

* checkstyle, session records update

* add npe for query methods in `VirtualMachine` interface

* removed unnecessary code

* add comment for upgradeModel()

Author: XiaofeiCao

sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/implementation/VirtualMachineScaleSetImpl.java

@@ -381,13 +381,13 @@ public String osDiskName() {
 
     @Override
     public UpgradeMode upgradeModel() {
-        // upgradePolicy is a required property so no null check
-        return this.innerModel().upgradePolicy().mode();
+        // flexible vmss won't have an upgrade mode
+        return this.innerModel().upgradePolicy() == null ? null : this.innerModel().upgradePolicy().mode();
     }
 
     @Override
     public boolean overProvisionEnabled() {
-        return this.innerModel().overprovision();
+        return ResourceManagerUtils.toPrimitiveBoolean(this.innerModel().overprovision());
     }
 
     @Override
@@ -397,6 +397,9 @@ public VirtualMachineScaleSetSkuTypes sku() {
 
     @Override
     public int capacity() {
+        if (this.innerModel().sku() == null) {
+            return 0;
+        }
         return ResourceManagerUtils.toPrimitiveInt(this.innerModel().sku().capacity());
     }
 
@@ -2283,7 +2286,11 @@ private VirtualMachineScaleSetNetworkConfiguration primaryNicConfiguration() {
 
     private static void associateBackEndsToIpConfiguration(
         String loadBalancerId, VirtualMachineScaleSetIpConfiguration ipConfig, String... backendNames) {
+        if (ipConfig == null || ipConfig.loadBalancerBackendAddressPools() == null) {
+            return;
+        }
         List<SubResource> backendSubResourcesToAssociate = new ArrayList<>();
+
         for (String backendName : backendNames) {
             String backendPoolId = mergePath(loadBalancerId, "backendAddressPools", backendName);
             boolean found = false;
@@ -2327,6 +2334,9 @@ private static void associateInboundNATPoolsToIpConfiguration(
 
     private static Map<String, LoadBalancerBackend> getBackendsAssociatedWithIpConfiguration(
         LoadBalancer loadBalancer, VirtualMachineScaleSetIpConfiguration ipConfig) {
+        if (ipConfig == null || ipConfig.loadBalancerBackendAddressPools() == null) {
+            return Collections.emptyMap();
+        }
         String loadBalancerId = loadBalancer.id();
         Map<String, LoadBalancerBackend> attachedBackends = new HashMap<>();
         Map<String, LoadBalancerBackend> lbBackends = loadBalancer.backends();
@@ -2343,6 +2353,9 @@ private static Map<String, LoadBalancerBackend> getBackendsAssociatedWithIpConfi
 
     private static Map<String, LoadBalancerInboundNatPool> getInboundNatPoolsAssociatedWithIpConfiguration(
         LoadBalancer loadBalancer, VirtualMachineScaleSetIpConfiguration ipConfig) {
+        if (ipConfig == null || ipConfig.loadBalancerInboundNatPools() == null) {
+            return Collections.emptyMap();
+        }
         String loadBalancerId = loadBalancer.id();
         Map<String, LoadBalancerInboundNatPool> attachedInboundNatPools = new HashMap<>();
         Map<String, LoadBalancerInboundNatPool> lbInboundNatPools = loadBalancer.inboundNatPools();
@@ -2388,6 +2401,9 @@ private static void removeLoadBalancerAssociationFromIpConfiguration(
 
     private static void removeAllBackendAssociationFromIpConfiguration(
         LoadBalancer loadBalancer, VirtualMachineScaleSetIpConfiguration ipConfig) {
+        if (ipConfig == null || ipConfig.loadBalancerBackendAddressPools() == null) {
+            return;
+        }
         List<SubResource> toRemove = new ArrayList<>();
         for (SubResource subResource : ipConfig.loadBalancerBackendAddressPools()) {
             if (subResource
@@ -2405,6 +2421,9 @@ private static void removeAllBackendAssociationFromIpConfiguration(
 
     private static void removeAllInboundNatPoolAssociationFromIpConfiguration(
         LoadBalancer loadBalancer, VirtualMachineScaleSetIpConfiguration ipConfig) {
+        if (ipConfig == null || ipConfig.loadBalancerInboundNatPools() == null) {
+            return;
+        }
         List<SubResource> toRemove = new ArrayList<>();
         for (SubResource subResource : ipConfig.loadBalancerInboundNatPools()) {
             if (subResource
@@ -2422,6 +2441,9 @@ private static void removeAllInboundNatPoolAssociationFromIpConfiguration(
 
     private static void removeBackendsFromIpConfiguration(
         String loadBalancerId, VirtualMachineScaleSetIpConfiguration ipConfig, String... backendNames) {
+        if (ipConfig == null || ipConfig.loadBalancerBackendAddressPools() == null) {
+            return;
+        }
         List<SubResource> toRemove = new ArrayList<>();
         for (String backendName : backendNames) {
             String backendPoolId = mergePath(loadBalancerId, "backendAddressPools", backendName);
@@ -2440,6 +2462,9 @@ private static void removeBackendsFromIpConfiguration(
 
     private static void removeInboundNatPoolsFromIpConfiguration(
         String loadBalancerId, VirtualMachineScaleSetIpConfiguration ipConfig, String... inboundNatPoolNames) {
+        if (ipConfig == null || ipConfig.loadBalancerInboundNatPools() == null) {
+            return;
+        }
         List<SubResource> toRemove = new ArrayList<>();
         for (String natPoolName : inboundNatPoolNames) {
             String inboundNatPoolId = mergePath(loadBalancerId, "inboundNatPools", natPoolName);

sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/VirtualMachineScaleSet.java

@@ -174,7 +174,7 @@ Mono<RunCommandResult> runShellScriptInVMInstanceAsync(
     /** @return the name of the OS disk of virtual machines in the scale set */
     String osDiskName();
 
-    /** @return the upgrade model */
+    /** @return the upgrade model, null for scale set with {@link OrchestrationMode#FLEXIBLE} */
     UpgradeMode upgradeModel();
 
     /** @return true if over provision is enabled for the virtual machines, false otherwise */

sdk/resourcemanager/azure-resourcemanager-compute/src/test/java/com/azure/resourcemanager/compute/VirtualMachineScaleSetOperationsTests.java

@@ -11,6 +11,7 @@
 import com.azure.resourcemanager.authorization.models.BuiltInRole;
 import com.azure.resourcemanager.authorization.models.RoleAssignment;
 import com.azure.resourcemanager.compute.fluent.models.VirtualMachineScaleSetInner;
+import com.azure.resourcemanager.compute.implementation.VirtualMachineScaleSetImpl;
 import com.azure.resourcemanager.compute.models.ImageReference;
 import com.azure.resourcemanager.compute.models.KnownLinuxVirtualMachineImage;
 import com.azure.resourcemanager.compute.models.OperatingSystemTypes;
@@ -1724,4 +1725,70 @@ public void canGetOrchestrationType() {
         Assertions.assertEquals(vmss2.orchestrationMode(), OrchestrationMode.FLEXIBLE);
     }
 
+    @Test
+    public void npeProtectionTest() throws Exception {
+        String euapRegion = "eastus2euap";
+
+        final String vmssName = generateRandomResourceName("vmss", 10);
+        ResourceGroup resourceGroup = this.resourceManager.resourceGroups().define(rgName)
+            .withRegion(euapRegion)
+            .create();
+
+        VirtualMachineScaleSetImpl vmss = (VirtualMachineScaleSetImpl) this.computeManager
+            .virtualMachineScaleSets()
+            .define(vmssName)
+            .withRegion(euapRegion)
+            .withExistingResourceGroup(resourceGroup)
+            .withFlexibleOrchestrationMode()
+            .create();
+
+        vmss.orchestrationMode();
+        vmss.computerNamePrefix();
+        vmss.osType();
+        vmss.osDiskCachingType();
+        vmss.osDiskName();
+        vmss.upgradeModel();
+        vmss.overProvisionEnabled();
+        vmss.sku();
+        vmss.capacity();
+        vmss.getPrimaryNetwork();
+        vmss.getPrimaryInternetFacingLoadBalancer();
+        vmss.listPrimaryInternetFacingLoadBalancerBackends();
+        vmss.listPrimaryInternetFacingLoadBalancerInboundNatPools();
+        vmss.getPrimaryInternalLoadBalancer();
+        vmss.listPrimaryInternalLoadBalancerBackends();
+        vmss.listPrimaryInternalLoadBalancerInboundNatPools();
+        vmss.primaryPublicIpAddressIds();
+        vmss.vhdContainers();
+        vmss.storageProfile();
+        vmss.networkProfile();
+        vmss.extensions();
+        vmss.virtualMachinePriority();
+        vmss.billingProfile();
+        vmss.plan();
+        vmss.virtualMachineEvictionPolicy();
+        vmss.listNetworkInterfaces();
+        vmss.isManagedDiskEnabled();
+        vmss.isManagedServiceIdentityEnabled();
+        vmss.systemAssignedManagedServiceIdentityTenantId();
+        vmss.systemAssignedManagedServiceIdentityPrincipalId();
+        vmss.managedServiceIdentityType();
+        vmss.userAssignedManagedServiceIdentityIds();
+        vmss.availabilityZones();
+        vmss.isBootDiagnosticsEnabled();
+        vmss.bootDiagnosticsStorageUri();
+        vmss.managedOSDiskStorageAccountType();
+        vmss.virtualMachinePublicIpConfig();
+        vmss.isIpForwardingEnabled();
+        vmss.isAcceleratedNetworkingEnabled();
+        vmss.networkSecurityGroupId();
+        vmss.isSinglePlacementGroupEnabled();
+        vmss.applicationGatewayBackendAddressPoolsIds();
+        vmss.applicationSecurityGroupIds();
+        vmss.doNotRunExtensionsOnOverprovisionedVMs();
+        vmss.proximityPlacementGroup();
+        vmss.additionalCapabilities();
+        vmss.orchestrationMode();
+    }
+
 }